From: Jeff Garzik <firstname.lastname@example.org>
To: Alan Cox <email@example.com>
Cc: Paul Gortmaker <firstname.lastname@example.org>,
Linux Kernel Mailing List <email@example.com>
Subject: Re: [PATCH] 2.6.9 Use skb_padto() in drivers/net/8390.c
Date: Sat, 19 Feb 2005 00:20:44 -0500 [thread overview]
Message-ID: <4216CCAC.firstname.lastname@example.org> (raw)
Alan Cox wrote:
> On Llu, 2005-01-10 at 02:41, Paul Gortmaker wrote:
>>Using rdtscl over the area affected by the patch on the two variants for a
>>sample of 234 small packets, I see an average of 4141 for using the
>>existing stack scratch area, and 4162 for using skb_padto. That is a
>>difference of about 0.5%, which is significantly less than the typical
>>spread in the samples themselves. To help give a relevant scale, feeding
>>it a larger 1400 byte packet comes in at around 60,000 cycles on this
>>particular box. Am I being optimistic to see this as good news -- meaning
>>that there is no longer a need for driver specific padto implementations,
>>whereas it looks like there was back when you did your tests?
> It means that padto has improved a lot (or the underlying allocators).
> It also still means the patch makes the code slower and introduces
> changes that have no benefit into the kernel, so while its good to see
> its not relevant its still a pointless change.
So the verdict is to revert?
next prev parent reply other threads:[~2005-02-19 5:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <41DED9FA.email@example.com>
2005-01-08 8:33 ` [PATCH] 2.6.9 Use skb_padto() in drivers/net/8390.c] Paul Gortmaker
2005-01-08 15:45 ` Alan Cox
2005-01-10 2:41 ` [PATCH] 2.6.9 Use skb_padto() in drivers/net/8390.c Paul Gortmaker
2005-01-10 18:28 ` Alan Cox
2005-02-19 5:20 ` Jeff Garzik [this message]
2005-02-19 14:06 ` Alan Cox
[not found] <200501070309.j0739IG6007753@hera.kernel.org>
2005-01-07 15:46 ` Alan Cox
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).