linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-net@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/net/smc-mca.c: cleanups
Date: Sat, 19 Feb 2005 03:41:47 -0500	[thread overview]
Message-ID: <4216FBCB.8040807@pobox.com> (raw)
In-Reply-To: <20050219083431.GN4337@stusta.de>

Adrian Bunk wrote:
> This patch contains the following cleanups:
> - make a needlessly global function static
> - make three needlessly global structs static
> 
> Since after moving the now-static stucts to smc-mca.c the file smc-mca.h 
> was empty except for two #define's, I've also killed the rest of 
> smc-mca.h .

It looks like the structs should be 'static const', not just 'static'.

This comment is applicable to similar changes, also.  Use 'const' 
whenever possible.

	Jeff




  reply	other threads:[~2005-02-19  8:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-19  8:34 [2.6 patch] drivers/net/smc-mca.c: cleanups Adrian Bunk
2005-02-19  8:41 ` Jeff Garzik [this message]
2005-02-19  9:09   ` Arjan van de Ven
2005-02-19  9:18     ` Jeff Garzik
2005-02-19 15:23     ` Willy Tarreau
2005-02-19 15:43       ` Arjan van de Ven
2005-02-20 10:37         ` Herbert Xu
2005-02-21  1:26 ` Jeff Garzik
2005-02-21 14:48   ` Adrian Bunk
2005-03-12 22:27 Adrian Bunk
2005-03-27 14:34 Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4216FBCB.8040807@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).