* [2.6 patch] drivers/net/via-rhine.c: make a variable static
@ 2005-02-19 8:44 Adrian Bunk
2005-02-19 8:47 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2005-02-19 8:44 UTC (permalink / raw)
To: rl; +Cc: jgarzik, linux-net, linux-kernel
This patch makes a needlessly global variable static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.11-rc3-mm2-full/drivers/net/via-rhine.c.old 2005-02-16 18:56:59.000000000 +0100
+++ linux-2.6.11-rc3-mm2-full/drivers/net/via-rhine.c 2005-02-16 18:57:05.000000000 +0100
@@ -390,7 +390,7 @@
#ifdef USE_MMIO
/* Registers we check that mmio and reg are the same. */
-int mmio_verify_registers[] = {
+static int mmio_verify_registers[] = {
RxConfig, TxConfig, IntrEnable, ConfigA, ConfigB, ConfigC, ConfigD,
0
};
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] drivers/net/via-rhine.c: make a variable static
2005-02-19 8:44 [2.6 patch] drivers/net/via-rhine.c: make a variable static Adrian Bunk
@ 2005-02-19 8:47 ` Jeff Garzik
2005-02-21 14:48 ` [2.6 patch] drivers/net/via-rhine.c: make a variable static const Adrian Bunk
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2005-02-19 8:47 UTC (permalink / raw)
To: Adrian Bunk; +Cc: rl, linux-net, linux-kernel
Adrian Bunk wrote:
> This patch makes a needlessly global variable static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.11-rc3-mm2-full/drivers/net/via-rhine.c.old 2005-02-16 18:56:59.000000000 +0100
> +++ linux-2.6.11-rc3-mm2-full/drivers/net/via-rhine.c 2005-02-16 18:57:05.000000000 +0100
> @@ -390,7 +390,7 @@
>
> #ifdef USE_MMIO
> /* Registers we check that mmio and reg are the same. */
> -int mmio_verify_registers[] = {
> +static int mmio_verify_registers[] = {
> RxConfig, TxConfig, IntrEnable, ConfigA, ConfigB, ConfigC, ConfigD,
> 0
static const
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* [2.6 patch] drivers/net/via-rhine.c: make a variable static const
2005-02-19 8:47 ` Jeff Garzik
@ 2005-02-21 14:48 ` Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2005-02-21 14:48 UTC (permalink / raw)
To: Jeff Garzik; +Cc: rl, linux-net, linux-kernel
On Sat, Feb 19, 2005 at 03:47:16AM -0500, Jeff Garzik wrote:
> Adrian Bunk wrote:
>...
> >-int mmio_verify_registers[] = {
> >+static int mmio_verify_registers[] = {
> > RxConfig, TxConfig, IntrEnable, ConfigA, ConfigB, ConfigC, ConfigD,
> > 0
>
> static const
Updated patch below.
<-- snip -->
This patch makes a needlessly global variable static const.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.11-rc3-mm2-full/drivers/net/via-rhine.c.old 2005-02-16 18:56:59.000000000 +0100
+++ linux-2.6.11-rc3-mm2-full/drivers/net/via-rhine.c 2005-02-16 18:57:05.000000000 +0100
@@ -390,7 +390,7 @@
#ifdef USE_MMIO
/* Registers we check that mmio and reg are the same. */
-int mmio_verify_registers[] = {
+static const int mmio_verify_registers[] = {
RxConfig, TxConfig, IntrEnable, ConfigA, ConfigB, ConfigC, ConfigD,
0
};
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-02-21 14:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-02-19 8:44 [2.6 patch] drivers/net/via-rhine.c: make a variable static Adrian Bunk
2005-02-19 8:47 ` Jeff Garzik
2005-02-21 14:48 ` [2.6 patch] drivers/net/via-rhine.c: make a variable static const Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).