linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Malcolm Priestley <tvboxspy@gmail.com>
To: Oscar Carter <oscar.carter@gmx.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Quentin Deslandes <quentin.deslandes@itdev.co.uk>,
	Amir Mahdi Ghorbanian <indigoomega021@gmail.com>,
	Stefano Brivio <sbrivio@redhat.com>,
	"John B. Wyatt IV" <jbwyatt4@gmail.com>,
	Colin Ian King <colin.king@canonical.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: vt6656: Fix functions' documentation
Date: Sun, 19 Apr 2020 10:22:50 +0100	[thread overview]
Message-ID: <42190e0e-4167-3cd6-0e52-d240ae67a502@gmail.com> (raw)
In-Reply-To: <20200419074717.GA3244@ubuntu>



On 19/04/2020 08:47, Oscar Carter wrote:
> On Sat, Apr 18, 2020 at 07:05:53PM +0100, Malcolm Priestley wrote:
>> Actually I don't really think the function descriptions are needed at all the
>> names of the functions are enough.
>>
> Then, it would be better leave the documentation as it was before or remove it?
> 

I would remove them all except for comments inside functions.

Regards

Malcolm

  reply	other threads:[~2020-04-19  9:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-18 12:36 [PATCH 0/2] staging: vt6656: Check the return value of vnt_control_out_* calls Oscar Carter
2020-04-18 12:36 ` [PATCH 1/2] " Oscar Carter
2020-04-18 12:36 ` [PATCH 2/2] staging: vt6656: Fix functions' documentation Oscar Carter
2020-04-18 18:05   ` Malcolm Priestley
2020-04-19  7:47     ` Oscar Carter
2020-04-19  9:22       ` Malcolm Priestley [this message]
2020-04-19 10:14         ` Oscar Carter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42190e0e-4167-3cd6-0e52-d240ae67a502@gmail.com \
    --to=tvboxspy@gmail.com \
    --cc=colin.king@canonical.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=indigoomega021@gmail.com \
    --cc=jbwyatt4@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oscar.carter@gmx.com \
    --cc=quentin.deslandes@itdev.co.uk \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).