From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752072AbcIOQ6B (ORCPT ); Thu, 15 Sep 2016 12:58:01 -0400 Received: from mail-bl2nam02on0059.outbound.protection.outlook.com ([104.47.38.59]:52979 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750794AbcIOQ5t (ORCPT ); Thu, 15 Sep 2016 12:57:49 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Subject: Re: [RFC PATCH v2 15/20] iommu/amd: AMD IOMMU support for memory encryption To: Borislav Petkov References: <20160822223529.29880.50884.stgit@tlendack-t1.amdoffice.net> <20160822223820.29880.17752.stgit@tlendack-t1.amdoffice.net> <20160912114550.nwhtpmncwp22l7vy@pd.tnic> <27bc5c87-3a74-a1ee-55b1-7f19ec9cd6cc@amd.com> <20160914144139.GA9295@nazgul.tnic> CC: , , , , , , , , , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Arnd Bergmann , Jonathan Corbet , Matt Fleming , Joerg Roedel , Konrad Rzeszutek Wilk , Andrey Ryabinin , Ingo Molnar , Andy Lutomirski , "H. Peter Anvin" , Paolo Bonzini , Alexander Potapenko , Thomas Gleixner , Dmitry Vyukov From: Tom Lendacky Message-ID: <421c767b-2410-2537-4f4e-b70670898fee@amd.com> Date: Thu, 15 Sep 2016 11:57:41 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160914144139.GA9295@nazgul.tnic> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: YTXPR01CA0031.CANPRD01.PROD.OUTLOOK.COM (10.165.183.169) To BN6PR12MB1137.namprd12.prod.outlook.com (10.168.226.139) X-MS-Office365-Filtering-Correlation-Id: 0572b55f-c098-498c-8111-08d3dd896b74 X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1137;2:tVmi+skf9OIqQJvdzjp9wIn9fa0Y7sSxnQz0+EY/zyoQdvVz05TgZMxggrNYU2s4VS+Oc1gVgKJIQfJ2iEd483mKeLdLDL3nVLxO1iDBj9r8RRageJjLqmHRZ4KKOWAGJAwyhiPXibfE7ofA/0XDMbPKvJ7LCgRyHAhVgVBFRy2DMarfjudY2KFlvQjOd/zn;3:sKcdIR6s9FnsB2qzvTG4PMMtVZy5MUOr2OVDdekyFI+IYA3PEwYUJtvxcn0gl/vMdpsUjUxq1BtdO7VV1hu4IkReLAgkCxb2D6GQ24h9F8c2Azj0oZGgAGB/KDPQ/1aG;25:fLPsbjn3te5+x9LTZOG1SGs6S7i3SMOlV3GOIdc6wMMl6Lirytkwhr1fHABUIBf3pZkmWVUCvVeC+g0L8Z95SONb22KBuc8GfmSa40FH0/Od16ckPgZo7LpKhcFaQRrEdyXD8KGhNzd2i4uAKbOfQeA2h3oJCUpqfg6gEz+n3+QMlEETHlMmwJLrJSYshCY1B18lLh/NjvILZ+y8UIDLYKnECaevuIHfyHhD9R0erDPFNiN++Su1rdIsamf/Gk/ZXehduT1LD7E7Qp+kS21Im5+/Cp1tk11Ys/EEqe4mon8cKQeJ6suWxaRX9UNKVpDM15HkO6H7eoSw52T1qRatcebwQ9YBucEo+/TayL2d5DdsXmcSccfvT7jiC192xt9AoJa8//QEVxO2hwAphBAoMP2t+uxIvVTAR9goE9e0qrA= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1137; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1137;31:xqKZev+Pn3Chag9vJgDlgc6oblbTD7BeNKzdX6nKwsVMNqzkPAMTptLKzTin39+vUq+PGgs2Tu5DVn8q21ddJZRLLjoz5x+f1W7V2g4MddXVEvx+2ZtALPJNbJirw3mTCckW2e0ZzSs1h1Z8OzmXiiNHC0nXktn+1HBE36R2ZRgAmxoh4FdDQ8KX8OoMdiXzotaXU2D/RHTqeTvKH+WF+MMYbI6AScES61jLXSf6iF8=;20:zlEoBv7btuAUzUWLoniEa517ngS7avtLphKzfbv81W+jS6a2bPEcDIXPnOqBSGZpkPdf64drVtWy+PdOaT5DqWHp1Xz8vcD7pJ0tpfqbh6exadknELGntkZ1yArmtJjixYqcfF7TTBzbXkUsoidGO4iw0osKac/bkwTBit3pObE71j4ZE4GsQhiD04HSsrePFKkOd5ycLj0uqCY7gYDkLj/8DJzs3i+RjlmeJ5D6trhbgEjFiAVUEtCBipzuC2dCJjakDt2xSqjIx037ceEKk4QfTlfRFfzAxeibItKzWSo+/QYdMjQe9Ajs6tKR7pu4VFYiAL/a9atsHFJl5fqXTnlN6ZShw978LeUBjP0xTVpgO43q7+HeHMV2UBROk99/hAP5keDdNOtvCBP2cIt0BjZalhUBfmaaoGGfU0WPxOqdHYkx+2+oDt+W02RJTnJYiFoWRBPrqfzjefVImK6PzJ9tCpZIMDi7Chgy81vwIajhmZfpzgPvt5hlgU/+ytcH X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:BN6PR12MB1137;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1137; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1137;4:In/poFTvhxVBu+NokiMZOh6KMAtv6Xd2t698QJDc40TabR3lm3QfG4+7Dxp0EZVPS0q+FkgNc4JTp5v1diRhPxqf1XfCcu7unl9WmLMwlSkenIUWl+mdPSIqSfxAN0GbZivT6SaNx1P2qVW4fSeCP8V7Y0hDVYwT97p6aYXo8x0eTwYAFeSA+jxXt3p/UVwkjSZSUfyjm2ZCQPZS/Zw44oNcUAE9mMzv7irIIGy5Fsjgy6l9V5k9Sjbas3BaJVIenUhPXb4DjylDeNUTmjB9dGY4ULQul0yGnYFyNx9il7IKtrggGyRMY2nDPQ+yx1TLcCYSLNtkJ2e3oIOZdYiTmcAn9RjjNAQdr+7+r/uKJ/nA3pCObFzuno7979bLJpfvXDcBcb31T4N2DvSMc6hlzA== X-Forefront-PRVS: 0066D63CE6 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(189002)(24454002)(199003)(377454003)(76176999)(50986999)(189998001)(2950100001)(305945005)(54356999)(33646002)(230700001)(110136003)(77096005)(65826007)(86362001)(586003)(81166006)(101416001)(36756003)(8676002)(4326007)(4001350100001)(68736007)(83506001)(105586002)(81156014)(7416002)(106356001)(3846002)(6116002)(31686004)(42186005)(50466002)(93886004)(2906002)(64126003)(7846002)(66066001)(65956001)(7736002)(65806001)(97736004)(47776003)(92566002)(23676002)(5660300001)(31696002)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1137;H:[10.236.18.82];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjEyTUIxMTM3OzIzOmt6SVJNcjZqNHo2NWF1NFZON0lLd0NiaUtZ?= =?utf-8?B?Q0duTFhoQU1QbjR2emg0aXlTZEdIdGE5UStaRU1sT1VTUUJOMEhlQy92L2lB?= =?utf-8?B?SlJmZjQ2OEdGanlsekNYVEJXSkN4UjcyQVZra0ZFYUhtaHlOOCtZaWVZYTBs?= =?utf-8?B?SDR2VklKUFJnRERDRFM1L3BYc3VHM3d6ZTJsdVBJS0Zjc3plMTYxRld3Ritu?= =?utf-8?B?M3gzMlVYa0lZOEQyWXIxQm5FclNzeUJ1Y3JpZXYwSzEvTkFwUlU1YTZMTmtr?= =?utf-8?B?dEVHOCs3ejZzQ3JzaVg5V3lpMWRKZ1NxRjBXYzhxZWJVNVQwemhqc1BVU2Rt?= =?utf-8?B?dTJ0Wis3M3pla2RVS291K0pLZ3p6UTZFclZGRks2WiszQlQxdjlDMkQxUzRK?= =?utf-8?B?TFRaWE5FWEZxU3pjRVFtWGtWVzN4MVVTWnpCV2VOaFYyN0t5UEloZHA2dU95?= =?utf-8?B?NjVXMlE3b2U1b2Vya3dpUng3QWRzLy9oK2V6RkUrVEF2VEozb0JJMVYwTGNa?= =?utf-8?B?OU5ORWhqUTBuUVBTNElJblA0dFlic0JPRWZSNjljUUFpai9ISSs2V1FvWEtU?= =?utf-8?B?QlNTd2w0c2FWaG5tV25tZ1lVYjZzTjFrczQyN3JBN1pVUERQbkRtK0FybFRV?= =?utf-8?B?VEl4bk5kakxpVk5XR3FHbUFRT3l2M1J1SGpVUlJ3UDdvSk5FMTBPVlRTMENy?= =?utf-8?B?dmRyQlExZU9lNWRKQjEyL2p5MStOZWFtV2J4M3FnMVIyZzZMcmtQYzZReGFB?= =?utf-8?B?NVc1M01WUy92UENQdy9kNUNLVUgzQjNNZlJlRDE2SG5JQWNMa0NlWlloUDRx?= =?utf-8?B?ejBIUzRRUkJjRHYxTU45SXdhRis3ZHNXd2FzeVBxWFdOWXpvVEYrUEw4RkZC?= =?utf-8?B?dE4rWStOUmV2aVJ3WVBxNm1EdlFFZDl0NVAzQzBENzNpSEhBUnFqK0U2bnB5?= =?utf-8?B?TUc4L1VMazVNU3VSSmhxVGFqSUdaUFJ1S1BSYmRnaUUwMzR2Vi9sOHlyd2Vh?= =?utf-8?B?QlcvY3U2czBseE5QQVJmTnFrdXRqNGlXN2ZvQ0VjaVN2MVJOMFBUYnloV2o0?= =?utf-8?B?S1VyeUVUZkVSdDlaVE1BQ1lTV1h2OWpkbDVHTjFvM1JHM1piZVhPUmpiNHlF?= =?utf-8?B?T1hxNHc4cVFkQUdUb2hpUkwzblJiOU5vR2RCS00wMElEVi9nL242eU5jTVUy?= =?utf-8?B?V3dwWjJZdnIwMWZCWGxhZWNSTG5leFlIK1Y0Ti84c1VaSlRYMXM5SjRYcDFi?= =?utf-8?B?N1VETVgxamxqdGF4M3pIWnQ4T2pORW5nVWlTR1F1MXJHUEZxWlYwQ3VUQTJU?= =?utf-8?B?cEcxYmQ1ZEdFd3ppUjZ5WGpKNVcxWlJld3RHSXZwS1ZxK0xyVS9qWjE1Rm9T?= =?utf-8?B?V0NoajMvMTZRNGFOQ2pzR05nY2FwNlU0cXRQVXFJU2hsTkE3U0hnZnltb0V2?= =?utf-8?B?cHppdkZLRlIvSXRYQ0VINXl6UVJXZGgxWkd3UC9NeHdsWkEvYkZWbVhkdHhw?= =?utf-8?B?MzQ2dklqdG0wZllWMTR0L2RXVzRmMGtPQnByK1J3dm43OTNIcVZOUHNhdVl5?= =?utf-8?B?WmZsZEU3RkJpRVFrUStTN1FwVkoyTVl0YzV3MFMrQ3RTUnVmVlRqMXgvcTBJ?= =?utf-8?B?MXRyNVJuMG1YUXFEMVNFYWk2L2ZKTGxHcVZvOGRaeitKZHloT1BMN2lZdGd1?= =?utf-8?B?QjIveDNuakNmRHNkR2VSaWlqZjFDaTZiamg2NXBzMVg4eWhZQlhoS3NvVWpR?= =?utf-8?B?U1VXMjhNRWkvd2N3TEpKUT09?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1137;6:n0YXlSgfjR814QDvSivRy1BknFQ2Nh5ozIQ90DkSit49Rd5wlLfW8AoqoiqfoKcPa8l4Olzf6b+OJkYHGlgYRraOFxyYCdXKpvSekNABvx6ASGRD22IcuU1XEQd+rnlozp13+lsH6NbB9ZlNyj1X46OVERYHqW3moGG24XZf1CRki3SOls3j55gnn6QAirH86d4KGu0PGHkKmZoDbXBkNnBY57iIgNVJ2zrBryIODbMwRzAARLqjuiQY8IH6UPoIHQ4ERZWb4Dpm9oGjql07Q6t4EKrsTrn8Lfh1kdUPSyQ+CTpKBG78eufeF8Rjv3d1No7ARLk2vWeNpwm+ENOfbA==;5:HjB5LZQBxLogqf/4iUxPVx1qW+FU4FD0Mmw2cMdgaPFbeQuOnPJnI7F+CetMGJsjeqayDEcRXeMPCu4/P19klDTepgRCVBMMKjtaybROTXVfMiTRkteZSggRa0yRXMI0X9Rsb+lLdNY2MZAkZkBATA==;24:D2H5/XagMcv04Ty8QNp5hjbuvFX0mzKNunSMQjwzMrED29SNa5QcVDW2NkoHnl6/af0OXMTz7yWSs11Iu4tYrSPr0LumERAJqZ41p+01wSY=;7:EEQPbxsjtbF6Zbh2+5tX4s6GoFxDVa1Zp+vB63XdsFv+sIv7isgw4poNh0JGfKW+gNSPmNtU6/NmTw8y4fKlLSY7U1veLMHMnC3LWrvqDxS8ra2g1e1w65KtKruSNcleiO6YSJCc5AbB2N7gaS+pyr1+iAVY+DHIUaPkTV3rufSdTXtcn2j1KumrqJ0zfTjNMNdPFcUflItAVFfiq2p8e9qxk1sIYb7VpJ3FUKbtDHVCsoKqbM/n/IDbuisXh2CB SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1137;20:/ew6XVBfRNCq+OW1Uc47ubfQJkarTvXc7Nx8n4GJTiC0Gtj2G4QdqI4cLN1Fq/bjC60juOv2TpJemiVVcKmHjZ8lcvenCWxLIMTrm95LCJwXIBWHOVVY85t0PoNaeN5b0FK2nnkbFZmImvKz8pwsf+HPQ01QwomejTnJF/xcQoYXJ51x+raehQHS7h1sm6QfJwzlaL+69Dx3oGC9z2O7MKRgI5Q2+y5M6uIzvzEQfAFuSWkckfNrUuonc8E5f8yg X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2016 16:57:45.1900 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1137 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/14/2016 09:41 AM, Borislav Petkov wrote: > On Wed, Sep 14, 2016 at 08:45:44AM -0500, Tom Lendacky wrote: >> Currently, mem_encrypt.h only lives in the arch/x86 directory so it >> wouldn't be able to be included here without breaking other archs. > > I'm wondering if it would be simpler to move only sme_me_mask to an > arch-agnostic header just so that we save us all the code duplication. > > Hmmm. If I do that, then I could put an #ifdef in the header to include the asm/mem_encrypt.h if the memory encryption is configured, else set the value to zero. I'll look into this. One immediate question becomes do we keep the name very specific vs. making it more generic, sme_me_mask vs me_mask, etc. Thanks, Tom >