From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22BEAC3A5A0 for ; Mon, 19 Aug 2019 16:02:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E237520651 for ; Mon, 19 Aug 2019 16:02:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727698AbfHSQC1 (ORCPT ); Mon, 19 Aug 2019 12:02:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47532 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726390AbfHSQC0 (ORCPT ); Mon, 19 Aug 2019 12:02:26 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5383D3018FC6; Mon, 19 Aug 2019 16:02:26 +0000 (UTC) Received: from [10.18.17.153] (dhcp-17-153.bos.redhat.com [10.18.17.153]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C67C7859D6; Mon, 19 Aug 2019 16:02:25 +0000 (UTC) Subject: Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules To: Miroslav Benes , Masahiro Yamada Cc: Linux Kernel Mailing List , live-patching@vger.kernel.org, Linux Kbuild mailing list References: <20190509143859.9050-1-joe.lawrence@redhat.com> <20190509143859.9050-7-joe.lawrence@redhat.com> <20190812155626.GA19845@redhat.com> <6c7e4d19-b993-1c14-d6cf-6aa1ee891361@redhat.com> From: Joe Lawrence Message-ID: <42254ffc-6422-19e1-62a2-6abc23fd089a@redhat.com> Date: Mon, 19 Aug 2019 12:02:25 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Mon, 19 Aug 2019 16:02:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/19/19 3:31 AM, Miroslav Benes wrote: > On Mon, 19 Aug 2019, Masahiro Yamada wrote: > >> >> I can review this series from the build system point of view, >> but I am not familiar enough with live-patching itself. >> >> Some possibilities: >> >> [1] Merge this series thru the live-patch tree after the >> kbuild base patches land. >> This requires one extra development cycle (targeting for 5.5-rc1) >> but I think this is the official way if you do not rush into it. > > I'd prefer this option. There is no real rush and I think we can wait one > extra development cycle. Agreed. I'm in no hurry and was only curious about the kbuild changes that this patchset is now dependent on -- how to note them for other reviewers or anyone wishing to test. > Joe, could you submit one more revision with all the recent changes (once > kbuild improvements settle down), please? We should take a look at the > whole thing one more time? What do you think? > Definitely, yes. I occasionally force a push to: https://github.com/joe-lawrence/linux/tree/klp-convert-v5-expanded as I've been updating and collecting feedback from v4. Once updates settle, I'll send out a new v5 set. -- Joe