From: "Christian König" <christian.koenig@amd.com>
To: Bernard <bernard@vivo.com>
Cc: Huang Rui <ray.huang@amd.com>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH] drm/ttm: cleanup coding style a bit
Date: Fri, 9 Apr 2021 13:07:50 +0200 [thread overview]
Message-ID: <42293377-a934-fb07-2677-3a8aff1a3ce5@amd.com> (raw)
In-Reply-To: <AJ6AJwDpDj4OHkToJ0s9uKqk.3.1617242344627.Hmail.bernard@vivo.com>
Am 01.04.21 um 03:59 schrieb Bernard:
>
> From: "Christian König" <christian.koenig@amd.com>
> Date: 2021-03-31 21:15:22
> To: Bernard Zhao <bernard@vivo.com>,Huang Rui <ray.huang@amd.com>,David Airlie <airlied@linux.ie>,Daniel Vetter <daniel@ffwll.ch>,dri-devel@lists.freedesktop.org,linux-kernel@vger.kernel.org
> Cc: opensource.kernel@vivo.com
> Subject: Re: [PATCH] drm/ttm: cleanup coding style a bit>Am 31.03.21 um 15:12 schrieb Bernard Zhao:
>>> Fix sparse warning:
>>> drivers/gpu/drm/ttm/ttm_bo.c:52:1: warning: symbol 'ttm_global_mutex' was not declared. Should it be static?
>>> drivers/gpu/drm/ttm/ttm_bo.c:53:10: warning: symbol 'ttm_bo_glob_use_count' was not declared. Should it be static?
>>>
>>> Signed-off-by: Bernard Zhao <bernard@vivo.com>
>> You are based on an outdated branch, please rebase on top of drm-misc-next.
>>
> Hi
>
> Sure, thanks for your review！
> I will fix this and resubmit this patch.
Found some time today to do it myself. Please review the patch I've just
send to you.
Thanks,
Christian.
>
> BR//Bernard
>
>> Regards,
>> Christian.
>>
>>> ---
>>> drivers/gpu/drm/ttm/ttm_bo.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
>>> index 101a68dc615b..eab21643edfb 100644
>>> --- a/drivers/gpu/drm/ttm/ttm_bo.c
>>> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
>>> @@ -49,8 +49,8 @@ static void ttm_bo_global_kobj_release(struct kobject *kobj);
>>> /*
>>> * ttm_global_mutex - protecting the global BO state
>>> */
>>> -DEFINE_MUTEX(ttm_global_mutex);
>>> -unsigned ttm_bo_glob_use_count;
>>> +static DEFINE_MUTEX(ttm_global_mutex);
>>> +static unsigned int ttm_bo_glob_use_count;
>>> struct ttm_bo_global ttm_bo_glob;
>>> EXPORT_SYMBOL(ttm_bo_glob);
>>>
>
prev parent reply other threads:[~2021-04-09 11:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 13:12 [PATCH] drm/ttm: cleanup coding style a bit Bernard Zhao
2021-03-31 13:15 ` Christian König
2021-04-01 1:59 ` Bernard
2021-04-09 11:07 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42293377-a934-fb07-2677-3a8aff1a3ce5@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@linux.ie \
--cc=bernard@vivo.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=ray.huang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).