From: Jerome Brunet <jbrunet@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>, Carlo Caione <carlo@caione.org>,
Kevin Hilman <khilman@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: clk: meson: add main controller clock input
Date: Fri, 30 Nov 2018 09:21:05 +0100 [thread overview]
Message-ID: <42372fe968835e59dae6aa1ce726b694f8a16a39.camel@baylibre.com> (raw)
In-Reply-To: <154353500665.88331.5525788751558555940@swboyd.mtv.corp.google.com>
On Thu, 2018-11-29 at 15:43 -0800, Stephen Boyd wrote:
> Quoting Jerome Brunet (2018-11-29 08:45:23)
> > Add the clock input of the main clock controller
> >
> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> > ---
> > Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
> > b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
> > index e950599566a9..79454869f96d 100644
> > --- a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
> > +++ b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
> > @@ -9,6 +9,8 @@ Required Properties:
> > "amlogic,gxbb-clkc" for GXBB SoC,
> > "amlogic,gxl-clkc" for GXL and GXM SoC,
> > "amlogic,axg-clkc" for AXG SoC.
> > +- clocks: phandle to the input clock of the controller, presumably the
> > + platform xtal.
>
> Any reason to not have clock-names?
Not really, I did not bother because there was only one input clock.
I can easily fix this
> I'd prefer to have them because then
> we can easily hook up providers with their parents based on strings. I
> suppose we'll have to support both modes of strings and numbers for
> connections, but that may be more for legacy reasons that could be
> avoided here if a clock-names property existed.
>
> >
> > - #clock-cells: should be 1.
> >
next prev parent reply other threads:[~2018-11-30 8:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 16:45 [PATCH 0/3] arm64: dts: meson: add clock controllers input clocks Jerome Brunet
2018-11-29 16:45 ` [PATCH 1/3] dt-bindings: clk: meson: add ao controller clock inputs Jerome Brunet
2018-11-29 23:43 ` Stephen Boyd
2018-11-29 16:45 ` [PATCH 2/3] dt-bindings: clk: meson: add main controller clock input Jerome Brunet
2018-11-29 23:43 ` Stephen Boyd
2018-11-30 8:21 ` Jerome Brunet [this message]
2018-11-29 16:45 ` [PATCH 3/3] arm64: dts: meson: add clock controller clock inputs Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42372fe968835e59dae6aa1ce726b694f8a16a39.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).