From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756777AbcHVTgN (ORCPT ); Mon, 22 Aug 2016 15:36:13 -0400 Received: from mail-bn3nam01on0060.outbound.protection.outlook.com ([104.47.33.60]:55218 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755921AbcHVTgJ (ORCPT ); Mon, 22 Aug 2016 15:36:09 -0400 X-Greylist: delayed 3657 seconds by postgrey-1.27 at vger.kernel.org; Mon, 22 Aug 2016 15:36:08 EDT Authentication-Results: spf=none (sender IP is 208.19.100.21) smtp.mailfrom=microsemi.com; users.sourceforge.net; dkim=none (message not signed) header.d=none;users.sourceforge.net; dmarc=none action=none header.from=microsemi.com; From: David Carroll To: SF Markus Elfring , "linux-scsi@vger.kernel.org" , "dl-esc-Aacraid Linux Driver" , "James E. J. Bottomley" , "Martin K. Petersen" CC: LKML , "kernel-janitors@vger.kernel.org" , Julia Lawall Subject: RE: [PATCH 1/7] aacraid: Use memdup_user() rather than duplicating its implementation Thread-Topic: [PATCH 1/7] aacraid: Use memdup_user() rather than duplicating its implementation Thread-Index: AQHR+3xf9A1uYGYn2k2lGvq0QCmAWKBVRimQ Date: Mon, 22 Aug 2016 18:00:28 +0000 Message-ID: <423FD6710FB8FB4F8728F93591889F9A15FA8E64@avsrvexchmbx1.microsemi.net> References: <566ABCD9.1060404@users.sourceforge.net> <40d8607f-3934-c31f-3791-ef6a67d65d45@users.sourceforge.net> <23c56a66-74a6-6033-f209-ac3e4ba83e61@users.sourceforge.net> In-Reply-To: <23c56a66-74a6-6033-f209-ac3e4ba83e61@users.sourceforge.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.100.34.10] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:208.19.100.21;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(428002)(199003)(189002)(7846002)(86362001)(189998001)(105586002)(81166006)(106466001)(53416004)(106116001)(33656002)(2501003)(7736002)(54356999)(5660300001)(23676002)(6116002)(2906002)(3846002)(9686002)(102836003)(7696003)(50466002)(81156014)(305945005)(8676002)(586003)(5250100002)(8936002)(97736004)(68736007)(19580405001)(2950100001)(2900100001)(2920100001)(4326007)(11100500001)(87936001)(5001770100001)(55846006)(101416001)(626004)(356003)(92566002)(76176999)(50986999)(69596002)(47776003)(104016004)(19580395003);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0201MB1900;H:avsrvexchhts1.microsemi.net;FPR:;SPF:None;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11OLC003;1:U7YCm2kWiN6ZrUDUoadhE15uDlEvSLwXkrZtIU/L18VcY2gX6K34klJtmqDverWym2s7H0ULyNRpy2nBIL6Kd85JbDjKOV7XBAWwcIAbx64Vfw1kZdhU/BYSxYHkwP8WB54G+ohBxReTJyT90gwG+GMWF4IqmkfITap5pZHgWOcGGw5+ZZ9CCy2HW8km58CNt08XuuFVGuKCg7WaTuSFjLJNCoq8a/HQjm8i3MSSh7x0lIm8WHYvXlvYNl1Z661Di96hBLwlMl6Qgf6qMKeLn2N4Er78x8Uhy/jJcXzrkZmKs61fKfXcc/D6uKLh+rnVeKFSfOuuaI3uBU+8eaqmzNCmBk6pXAvKpNUApC2s+AbKX5DEwsKI80RtzZccMteZGNGI8UUfaNkojndUCkqZG8Yk+IfEvcqczGrDCIMXlstjUCEduJ2jGKc+t41wfQ/HHqz3Ad3CXGBcJoTRzDJWAI3pIxvXeFZ6icn3m01zrP915oLg9T7CPKMROe461v4WxDYzbHI7CXfqM80kFU+CGN8jDjEqAB5bWqQ+UIDlstk= X-MS-Office365-Filtering-Correlation-Id: 542d6640-11e6-4f95-9473-08d3cab63871 X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1900;2:dzxxvpBkZdpCJl7nw6jCqkLl87owr195TXB0JBMv/ppR4hPPLXRKTH2LfhLJinCfPQt+Xv+oWkZBzhlXbYX3FORonSM0vfkhnkfADmjRlxpDM+Y0nfRbVJDfRgVBWlc+A8YUmhrGfX/ufwArLNsZuV2lqZ109eWT958jl35MOOb2Mkr2xAF1Mx6JvsZi3e/O;3:iKGBw2Ts7efGxhMPt44GO7GwTtfw/IeEu/f/K5zxxz+FcEiyWBVy7zsRbyMtDxvScwHs9+PmIHieX8j9QL3RRm4MmiY1mIo/6G0nrVbWjHqR/akqHN/L73Lffr0cNHVKbunNgmzdg9lzDmhsbIgLLVZLt9rg5n3Qkxntp/ohlb+9gnPYn3URUZRuz7tH1uQe7PeAoy/yipEzH2kz1Qows28H8hFeJFzno8TXmEbjang=;25:tPgkD6gbzmHcW1wpXNfNkmVZBW6eCavVgWOE5amzx6wNvcXmOS45hL0Wp138C2PuU39RDdDLgko3h2Tak/u4BfqlnOgLqls1GCryEVIQququxMPj4/2uxjGMYZB1pdVYXd1OSAhdtNybSciG2gY8xEATyNooYHQ5Pt21EXcVewH/lgrOp669OsoM+ISYXRVGqdBTOI3UhIVqN7xjS4ME5XwZliiorjhhdHEPdCuWqh8ARpW4ih2Rf0wqLJecdwD4A2pUNqdNW/KMQe9+h2V5v5tA7YEl4/dLxFsOUepWHzQ2FG1IFL002EFOHDe2YizfDFh8B9TGjEtxqLNZBS+rJS8AVZhWHzipDU0jMSQ3ZS4+cJTxRu3DzxdVs2uL0f8km3cGN3Q/Lf7ph0Ld9msTjAdplVBD5LuYsQ7bYff+7G0= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0201MB1900; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1900;31:eRx617JgUA9RrNdkcGe/ovWausbNPqSC87pua2n6on3G7/AEn/ISNZJYP6xK07x4uKJkCWQPj+iLu6+6Dm6uYgb2ieCg3PfiN60zMb2fdBAvN8nOf2TcyRUmnl6AVDvtOhEm8EUeODl75oO0a+kN8YYYyKg0qLV3JJVgZ2dpXuzEEJ4SRiq83xR54mCzJMB3CsF0nKhZVtt/kDV1eiVmkwqFz5LUHKL4CkjpCieCF8U=;20:qrgzUahkpvODCxL61dlG3q1qyXxbHJzdQkTcXHh3UVKz1n1hmBSLRBOY4A9Heqwwj1fZtZHbG20Rp2nkdVCA/DCftoqTESHHcUNg42s4gabeWJWnk+dZsQmfextyr9cMZ7rPHIjaYxlmXF2G/31uSOPANGMxfYhsJ5oazNUkB07M0lzwb6zBXjSKgKAfnEqUtUJhi58q3sBNpaVypXox1SdtpmwkfHKO+ZQyzXzTa/x3CyO1YmfpAFnZb+f4yg8sy9fQC8YPANscoheycx3mEmAuUPbv7AKC6TbqqCpBkOlGO0lNgDjrrksMURLRLFaC0GTB5QCoj69z3o2/8RpvWcUXevqmRhq+IrKYD9xbH2mWYOEK1qj5jSgJaybPxxM773lTekOg/vaqUI0CPCRpmp50SpWWZ7IGueQEhpP2tJJonLDXq1bQK7KDuxTUF8y3Q1a4sF3RgM0IQ1Rj4ZVnlLL2ObrpSN2phdlVdRVTWqVWM4ovLuZ0AC+5ZJC83UAb X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42262312472803); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(13023025)(13024025)(8121501046)(13017025)(13018025)(13015025)(5005006)(3002001)(10201501046);SRVR:CY1PR0201MB1900;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0201MB1900; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1900;4:QHtFMowHr6zOYnSHUG/LKmwgn81h3TMIjSh5Zupb8pzw+lNVS3GZr7onZt3s9aUNIhTdtSrDWzBeAZzqZ+ehvv08eschjamcXXGfPyAcp+aZjKlnlm5WrMw401JqwQ+iq9nvagdrArN6J/R8SKXlDePB8uZB0+VPZV3Xa20FnYpMyfERx42erYp4zESGM59bwUSblf93BSTgFL4W1gzS+ukg3Dqy7xLNnX+DkpF3JLGp37mnalLIvohGc9pQNoLZrjJf6axccRrUexB//rHA4a1ldGon7OjCxzNcDRt/WFDl78QHtEFsSOgQblAetYx7jRKJNswOZZstUCWugd/EPHogjBxrcw9yZjbJRbcWLEHvMvazO7zkDfTPadOeHBmkXhZ7sjkI/V2H67NxYvC4D61+RqiRJrIrkZf9w+XBb4DzWQZDQhvXJNnfYhTTUCY/Hc+cgp5fIblAEPYT8zQXf1PP4enHUhz0MMduKA7nJGhtnUvsW8Uksj2Cx7Sssxqk7e8h3Py4Zrkuz16WTEKciw== X-Forefront-PRVS: 00429279BA X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAyMDFNQjE5MDA7MjM6UGxMd2g3VkpRRTdoTFBMRGxHUDdOOXl3?= =?utf-8?B?WWNNa0RXbHFOWEtNOEJTeVRpYVVwZ0dGd29sUFpicHRrZ2pzSnB2UFNIRU5X?= =?utf-8?B?dlJwWUNXclBNQityWkI5ck5HL1l1KzV1emRkK2E2M3NRR2R6WGcrRVVrYldQ?= =?utf-8?B?OXB5bVlDZkRVMm00RzFaQlZIS2laVzl4Z1FZRmVKcDV1RzFNdEdwMk9GblI1?= =?utf-8?B?YjRaZEtVT05PUk9aQ3UybHFqSmZYMmN4bHFOMm9JWGRuTUZjcXFwNFFZSUJv?= =?utf-8?B?ZzJHcjlFR3pGd0NlZStNaUttcG85QXFoNG9Sb2FIMGZPL2R1d0FPd1ZKYjVi?= =?utf-8?B?R2tSRnNzOGpwWVBRTmlaWFZOOGZKZUZ5SGFCNE9mQkRIcFVtL1d5Vm1ZVG05?= =?utf-8?B?YU1KVmM2VDdtK3hkU3UwTHpDbUxDU3Z5MklXNVRDTWpLK1BzeGtCWHR2ZnRP?= =?utf-8?B?TzlZUjY5RzA2YlVXZDlDWGtBTVNqS3BQOStQUmhtMHo3YytzU1hhT1doZlpj?= =?utf-8?B?S2hFMkpqL0ZMekRiZ3owUDdpRXloSnBpZCs4KzA0VkgxbnF2dkIyVk9ocHRw?= =?utf-8?B?a08zUVVBMG5CV2FqUFA1LzZ2bVBSblpFbmdURXFHSFlzNmJwVjl3dmRkLzJz?= =?utf-8?B?Q3BPYngrVjdyK3dDcTludnltUWZVU0hybEk1Z2s2TWV2Q253UFJrOGpuWUQ1?= =?utf-8?B?YUJ3dGpOMHliMkp6KzdYRGNJSHBvMUgwOHc5VnBCc0xoMWVVRk5HTmVZMHIr?= =?utf-8?B?V1R3L3lRWDBFYmVxb2NyZGpkS3JwaEpVZHN0eEc1aUwrSHFIUzdVeG13a1l5?= =?utf-8?B?VDkwRWYxWkdoZHlXc3hlYVI0RitvVUQ0dzY4ZFN6bGVaamhrSVNzL2F1QmI3?= =?utf-8?B?UlZyeVpnSUFBVzJ0MnZ6WldOZHQwTG9VMVVEbE01YyttRGRsOGVzS1J2ZmFm?= =?utf-8?B?bkp4dDhRemlZNTNWOCtnZGp4WHpqV05OK1hhWENmNEtqYndqNmh0WDNyQUxU?= =?utf-8?B?bDhBdDRwekdXclc1bmcyTjlCc3BOUm05OWJWUU5kRGtCc1hISW9JNzZMUm1r?= =?utf-8?B?QmxkdkR6RitmQ2o5RWtPblpoSDRTZkd5M1FuSC9ZZkdvWnh5SXlQOEdYQmxJ?= =?utf-8?B?elE3MGpLbGg2UVNOZ3dIQjdER2tHNlF5cW83SStSM0JPRTd0TjUvK2t0UjFV?= =?utf-8?B?WTN2QjRxTWZPUGF6dkVEdjA1ODN3akZHa0tkcHVZODJtK3BydFl6UGg5VlFG?= =?utf-8?B?VjJEdmMyVkRsZWRNVjJmalVSTy8rU1dKU3dGR1J6QlJFSW1ENkZEYzZoUmhL?= =?utf-8?B?SDdab0NMcTRQSzNqdkNmcTA0eDlSRHRRVkF5YUoxQWF4RTlQM0JBdGMvaiti?= =?utf-8?B?SFFPUlk4K25vTDVWR3NHY1EvN3duRTdrKzlZR3Q0dVlLdEJiWXFxRVg5ODhv?= =?utf-8?B?RktGbkZveEo1akMyeXY3WkVwOThraWxPRnJSbm1TOUQ3bUwxc1BxcXRZWVRv?= =?utf-8?B?QU53M2FKK3R1eUd6QVZTVVVYdlppMUlsTGJTc1JFS3hUek5zWkZXVHNGMGdM?= =?utf-8?B?TDRIcSt6TFN1eUU0VDNaYkRzU1haOFMyT05TRGQwTWl2K2o5bUFyMXd5eVFT?= =?utf-8?B?bEd2S015MU5oYnVaKzg0UTBxNHp0UHlBOUdKWGZVSGswYTZUMlA0eEh0VDk3?= =?utf-8?B?TVdPaEF2Y0hhTEVmeGFXYkRZSEh6bWlsY1c0WmdMV3dhNzkxbE5lUS8zV3FO?= =?utf-8?B?RDNlTStPN1RIM05HYnpZZUl3PT0=?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1900;6:chkHfFr/0PxG3P7eHYvJZSbi30TZQO5J0q+E6Ow9nbANdpN7VdA8+wH14Y6aGybMb0savgKAY/M9bdXvjSnCJAyk5AlGsAdlEGvPVJXEQGtiXZPSL3KM+rlGI/6Ofq/RmnxnkOM7Du6+/2I+SBNFhp8Phc3OHOuOeDcb2LYl28QzOpCcF5WRmDR1z28q9pF1CyV4BSs3OkfIHUNQzSUBpdReSPRYvLt5SwaCgarbAAjbi4axgi9zBzGM6+xufxt+5Nb4Jw1tK5gLllfynThn5BDGfnjSWAoEBgN/IYeQRWU=;5:ciRtSEwEoNsrDI8juys4awKA0H5ypw5wpi5KEEPaQsPtA6eLR9syJfea/yfRsp5qhbiC/adDmv69BbkLwEop/fAmf8m9xkPSoOVHmOm8h9ZxyqHQbxp3hFxjUkoe4JGMM7Rkw8/P+QRwrtE+Er/gwQ==;24:Fs6sqbZCUo9Ph+B30Arp0XIqd188XYXpEeFwSsGrDnRpxG6Ad+bcYTkw0ErlgYwerZfMd7K28EUNpoAaunvHZ/dujAk4NH/0NWreEdiRhGY=;7:CIkZ4/jPC0d5c3eRTdJlFwI2uePIClK+YjmVWgTlfcbTt0okJAUW+Q9nI6LBCtWUB1cPjd2h87Fm+hPWq12oJuM79KR33WhdDTL1ZK1TtXEoaK/QDQ/cVym1Oe/4QHEaKTcicL5NIbbEQa1KQQ+A/sLqTnPFrL85ZUTP0FAqx7bKTiI3OUr1iusnPMDpcEItkdNtGXaJn/nEz2tQYKfvc05jefmbC5hMblxD/K/aymQoQxU0iMquw8aVsT2NKyyg SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsemi.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2016 18:00:36.5766 (UTC) X-MS-Exchange-CrossTenant-Id: f267a5c8-86d8-4cc9-af71-1fd2c67c8fad X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f267a5c8-86d8-4cc9-af71-1fd2c67c8fad;Ip=[208.19.100.21];Helo=[avsrvexchhts1.microsemi.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB1900 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u7MJaJPN018013 > From: Markus Elfring > Date: Sat, 20 Aug 2016 20:05:24 +0200 > > Reuse existing functionality from memdup_user() instead of keeping duplicate > source code. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/scsi/aacraid/commctrl.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c > index 5648b71..1af3084 100644 > --- a/drivers/scsi/aacraid/commctrl.c > +++ b/drivers/scsi/aacraid/commctrl.c > @@ -526,15 +526,9 @@ static int aac_send_raw_srb(struct aac_dev* dev, void > __user * arg) > goto cleanup; > } > > - user_srbcmd = kmalloc(fibsize, GFP_KERNEL); > - if (!user_srbcmd) { > - dprintk((KERN_DEBUG"aacraid: Could not make a copy of the srb\n")); > - rcode = -ENOMEM; > - goto cleanup; > - } > - if(copy_from_user(user_srbcmd, user_srb,fibsize)){ > - dprintk((KERN_DEBUG"aacraid: Could not copy srb from user\n")); > - rcode = -EFAULT; > + user_srbcmd = memdup_user(user_srb, fibsize); > + if (IS_ERR(user_srbcmd)) { > + rcode = PTR_ERR(user_srbcmd); > goto cleanup; > } > > -- Hi Markus, Patch 2/7 should precede Patch 1/7, as falling into kfree() would not look pretty. Thanks, -Dave