From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753557AbdKGRk5 (ORCPT ); Tue, 7 Nov 2017 12:40:57 -0500 Received: from mail-sn1nam02on0050.outbound.protection.outlook.com ([104.47.36.50]:64592 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752163AbdKGRkz (ORCPT ); Tue, 7 Nov 2017 12:40:55 -0500 Authentication-Results: spf=pass (sender IP is 208.19.100.21) smtp.mailfrom=microsemi.com; arndb.de; dkim=none (message not signed) header.d=none;arndb.de; dmarc=bestguesspass action=none header.from=microsemi.com; From: Dave Carroll To: Arnd Bergmann , dl-esc-Aacraid Linux Driver , "James E.J. Bottomley" , "Martin K. Petersen" CC: Raghava Aditya Renukunta , Johannes Thumshirn , Hannes Reinecke , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] aacraid: use timespec64 instead of timeval Thread-Topic: [PATCH] aacraid: use timespec64 instead of timeval Thread-Index: AQHTV7WodLUKk38O1EKUOBGmWQPxAqMJLtVQ Date: Tue, 7 Nov 2017 17:40:13 +0000 Message-ID: <423FD6710FB8FB4F8728F93591889F9A6941C525@avsrvexchmbx2.microsemi.net> References: <20171107104613.3183755-1-arnd@arndb.de> In-Reply-To: <20171107104613.3183755-1-arnd@arndb.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.100.34.10] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:208.19.100.21;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(376002)(346002)(2980300002)(438002)(199003)(189002)(54356999)(53416004)(68736007)(97736004)(6116002)(50986999)(53936002)(8936002)(2920100001)(2900100001)(76176999)(33656002)(5660300001)(102836003)(69596002)(106466001)(8746002)(8676002)(81166006)(2950100002)(9686003)(7696004)(97756001)(5250100002)(81156014)(50466002)(189998001)(3846002)(478600001)(23726003)(316002)(54906003)(46406003)(356003)(229853002)(106002)(104016004)(55846006)(2906002)(6246003)(4326008)(305945005)(86362001)(47776003)(110136005)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR0201MB1826;H:avsrvexchhts1.microsemi.net;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD028;1:0GAqMeupyePgoOHZwPBz57xVqP7j1fARTISn3c+zRGgXSydMEVnuVIvmL5ttnOULkgOexweFHPdwv++DaYkjVb/mn1ID+NoA8KyA8kNRO+Yba6gzvnUzK6OcP24UNDpu X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6ef89ce3-3f3b-4977-8bb7-08d52606b124 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603249);SRVR:BLUPR0201MB1826; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1826;3:qJaoap+c5hMxvD9TKFtF9FG5mKhen9b35FeCxxqN42h/ReGhfFkMKhEE+HED0wuVRCRtRyfKGyZzDeCmIjrFgLEzMDqwiQ3r02zOwVqUfImK7ZRf6lvWikJoAje3DlHadcqwGxCnBvgIWede1lbV2nRjF8YLOQyCsjdUzEjH5XQji/fbFZzfxkW+lehQHfGg7IWrXWBKpEGRUzBS7e7KjQWVC9H+8/oba+TQfOcEdNMfhV/n7yjU2cUoq0LEhB4FJs1vdBeaeTVjOzOft1G9J8N2wWfEMqsqQ7DPhICrGlxJXCsOdvySj0bxbUqtN6Oo4bMgfhPcVxlSZRH6IgEeMtRIc0QcebpnyO6hDeI1bnI=;25:txZucakp8/ba5kHuLoXxCAbSZROgNrFo/me/CPdsYrbjkI35S2oDuZTnzZGraJiPdQAjtX41WoDrqDXLn68XkcRu3i42CcWcFi4adnTENCr4gDmoniwke5LiCKKPVvyYSBIga/KAJ13e7DodfgJfIgno4P4FcTKzRQFrBXAOGr+zFWm17HfYxxgX099mRzD+gado2HghjLdNT4T8Mn7gQ4uKzmYF4LgyFmBSydJeEoEw6d8K2DEX3cNqAFI/Z1IR9lyCZu+04H2L5lCHj9rhA30lr4iEIuVrlI0E1VqpEoaQKQaYZ3pnb3PEAW7GrCkubtB/tO1R8efGs/8Z+QWrlQ== X-MS-TrafficTypeDiagnostic: BLUPR0201MB1826: X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1826;31:mrji2mqbzOJcJIRrpo5FnYoVVnfLTQBujGNHRKAl1iVqjwYpH96k4VwKNLW9F2IJzI+UhkbRmRY5QH+qkvlZm+o9ZQrAm0FMkRXWaaSx5yvFIOZLZsODKOVKjCIoCeuw7J8Hvo6CPU11zQbU4HEkvQCyYO8IfZwgoOhSZB8bLt4i/lCKmghCC2YlYLHHVKbHNCrqW4c+hyol+LrFYocE2sckUqSoRbMbQBSoaeeEyJI=;20:wwCrMRCdf6p9m/PJAR68ZykY9VQnMLB5bHuoTBapV4VF+qfsPtBmgpipLpAPTYGpxNBX0VcaA40dZm8b5uyHSiliUE/v23FOLZ9s/CTBkGrPNpXIXaR3l93unWCQP2y5xkg1TA+Fvh/r95mPrJFZVjeLimSp7KARBvfGJbx0rVs/+ZzSYKP/WwyuqzLiI43/u4ycnVTLDIXDirSfS6YNL4oo9qm56U5fVyzpyXFr5BJmVhhNaSehGckU5BkcKE2ln/jyJ7SUjEU0C4QO0bH3ZvTMZIDOsjQuFBGg3a8rGbbh+Gac+V0LydjDfmCZ/6oxs/Qld4PNSHxI/4oYLxfYJDXqcQN6vBciF7rLOqF1+uJbiHUg+QLfgLYA98fTYKg45mECPI+XYkCYzbBIHtmQDBYiEekdDaM+CoW2lMEKKK/sldnAfMdik7eUy09iUOGBfADhImjHrSWXUFAJbJMYQu5kGP+cLd2EfZtc0c7SG+n4XIXMVAbIb0kobUpl0O8S X-Exchange-Antispam-Report-Test: UriScan:(72170198267865); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3231021)(3002001)(93006095)(93004095)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123555025)(20161123560025)(20161123558100)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BLUPR0201MB1826;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BLUPR0201MB1826; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1826;4:KyN6DQYcIsqoALluNk3JaaV0j2y9pMyWZjy1ha5KNIjWahGSznEPptlW1tUzCu2Gfq8/JL5u//Uy3qrGDOJitn1YZ46llQgMQ0sLHN6jh95Pxqu2ibNAxHyFPYsq5dqg598g3g/UqdEJl6IEXUQaGWbZA8bM1pMtKuSvAkjp7FY/mKQwYLPIEZoKsNoWtT4NlnAJTcyttG578HLRPFVJeFHjrV/DO6tYASSyWhfXoQcjA5MDA2yrxDvBba9edS/juy5fNvtUdHZ0YwxWEWVJ7AUEyV9p1cIT/Gq3OAH+vD20N4k6xR6Q2+zVm+zObwH5 X-Forefront-PRVS: 0484063412 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR0201MB1826;23:alvd/CelAKzko4AUJ3TAoCcPpa0pOFnJnX/vmJD?= =?us-ascii?Q?/sazTf0jAj2PPozFycEv+Owiw4D351qemiw6X7LdcclZHcYdiaNk4oDZ0TE6?= =?us-ascii?Q?b5jJLxGodb3meWzVKmDD9D7EYGtHAO/tZ7KqbQICFMurYHzg2yJgfyr7QiwN?= =?us-ascii?Q?kwXMofr1+kjEN6foH6TBU7wtRC+AefMdRuw5JukMDIT6ANKg7Gid2d+TrwHf?= =?us-ascii?Q?7i7F1qb20OFrptUHe0NGsYyWRot7mCXoUA8JdWyAAfnrnYnSK9cV68IuZMfm?= =?us-ascii?Q?5E3rX4krQMipkl44y1zcG6L2eBbh7jZKQNwvy0ChkJYTGTvHPGxoly55xXW3?= =?us-ascii?Q?7nux3Pbpg1XRl5UUNX/TYqoQlsU2poMNXumBmqfigAJl9AD+TIWLg4Xder8K?= =?us-ascii?Q?ogbAIX+T2TeJSNzVNdv+GSsJ48Bs7+HyWk+IOEHGAoXJQJ2tRC6u17L50PnZ?= =?us-ascii?Q?W3AW6msOXLxlsL5zdXnofWNjUXHP9E10XdsG+1Sq/ExBS3jMsDvBRT4/+dGL?= =?us-ascii?Q?9X17WQtr5E/NyvN5f3NGOXfYLmSH/ljAQUrhTqw7VYsJtb/thm81ebzi/oLY?= =?us-ascii?Q?lPx/UI1mUiJeO6M0OA8ugKoKHslDMRL6FdB/956L0zzDpBm06RiWMMEfjnM3?= =?us-ascii?Q?eklTvx9B+VlA6987plDHWRBahBVQpkt8rh2ayZfSRHYP+WWoMyvNzh3MGy/n?= =?us-ascii?Q?elX1xjMxHY209mSVeyccb4osunSa+zgN7fymoED9xnrw0zmBZObtp4+CqxXb?= =?us-ascii?Q?6wFqTI6XAYwBUX7meKLVOROAV2TNZuil4OpCxR9qfF4ooWZFda3PXJDGFchH?= =?us-ascii?Q?tDBT1p/cShsdJ/HS0t5/lHO8aU2nNRdFBMvn6IOpG9/1+BrjyFwbHb9W4M1j?= =?us-ascii?Q?mJQ5R++5maN1KQ/YQT9uog1zzohREiev51JESYT1ctR5XkFnHvT6RtpiV0lV?= =?us-ascii?Q?yLW48h4SLT6qGVbWlVoBghz0tfg9EyxS22gtSS9xej10UvwLw3/DHGb4ROSe?= =?us-ascii?Q?NJ3m/slLZ9qV4XnkXjZVQjgak0QPkSxG8Gyj/ns50Xkg5ltg0CpUN58LinGv?= =?us-ascii?Q?mm6WGXhYoJR0Ard5BC7yOD4TvAnRInLM/D0qmTP9GXlbOX1kEppQLsPdSKn2?= =?us-ascii?Q?zQJSbxyUZ5zMf46roUMXJBWTIMY7JeMk9ML1fKlnOLP44Qcn9xNGbyMPbOYy?= =?us-ascii?Q?p2tjPP4lstK42EFI4gPBJbZ77JgrO63kBIZ5uY38/BzN45Wr0+pWzSmaPp5Z?= =?us-ascii?Q?0s73fXCT3dqbDRmogbPM=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1826;6:VUxYbmP64QBgzWxm+Bssq3+Sr73ZTj1eubAaRZDwN24OGxwl/5pA095x82WTNAqSoe0Tyjpvm5O2nBTqejrh8ZCjvHn69YJ9Sac/BNtXSeVOsmcFZLxtct1OtRVFZxdkVk/M8CZ6UV93sZvvPGvxHYpqi5JhUJy2lJNvxcxArS0mPc11bxRHmgi39dY8QS01RcWx+lxwNO9rxQY/adBLaDab65EgPdVGwz5TALbvg4SkEyZXep+wNMGQO5pY0yHMMwdWeAPa9eXiCx5655Ucvg2lE3QYgufk5U0giuAOLr9UigcZk+3Pezzlabye7cY8GYmQvzu5dn3FYtnJoUelTEdxENk5RNLSuvy+//USlS4=;5:gTKGaMZa1Uyht4Ga+NcV7/F1Ci+mVjYTbAzfsHT8PGYQRi+s9t93e2p7u/wFr19bMf0KR+3/jxjujGZj0LRL593AvU0cYpzu6luKxZmjrj5SpSndwazHmYb6RuGQ1QYQOm1WqD6fJsCyJuhLOZYwJmNVmJTnpqQvd1O17XpRvRE=;24:0+RNY5KqQbZ9jAVwAY1GxLVA2m+XSu6WXFA8RL1bf0zZ96hydjGB0397ve8pS6hlavPmfYtZI5PfaNqEWeFGwd0LIT2SBf9CR68ZbW/rH+8=;7:8+8yXmnwDxn3UOGPfBDKx+zRTmQRr/QX2/ndWtvn+etGzFNxDuli+Wx2Pwx0VPfWnLSsFZQJJJkD2TbnS1aBbiq1vFYxgPZ47kHXTdRBTpWt/XZqKPwAuQkA4PsDStxCtPSoZwjFfks0ipijJwm5jKDlGDoqCE4V4oiX0/KzWqm4QZpiIRgDXuRMAJTuUy/1qtnBz0dStM5Wcks10gHcE/mM+63wXa+k5v+2glIEU792aVrjXfIzo9wvOVPUHA+N SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsemi.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2017 17:40:52.3138 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6ef89ce3-3f3b-4977-8bb7-08d52606b124 X-MS-Exchange-CrossTenant-Id: f267a5c8-86d8-4cc9-af71-1fd2c67c8fad X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f267a5c8-86d8-4cc9-af71-1fd2c67c8fad;Ip=[208.19.100.21];Helo=[avsrvexchhts1.microsemi.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0201MB1826 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vA7Hf2Y3018915 > > aacraid passes the current time to the firmware in one of two ways, > either as year/month/day/... or as 32-bit unsigned seconds. > > The first one is broken on 32-bit architectures as it cannot > go past year 2038. Using timespec64 here makes it behave properly > on both 32-bit and 64-bit architectures, and avoids relying > on signed integer overflow to pass times into the second interface. > > The interface used in aac_send_hosttime() however is still > problematic in year 2106 when 32-bit seconds overflow. Hopefully > we don't have to worry about aacraid by that time. > > Signed-off-by: Arnd Bergmann > --- Reviewed-by: Dave Carroll