From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5891CC432BE for ; Tue, 27 Jul 2021 15:47:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40D2661B52 for ; Tue, 27 Jul 2021 15:47:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237175AbhG0PrL (ORCPT ); Tue, 27 Jul 2021 11:47:11 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:30482 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237116AbhG0PrG (ORCPT ); Tue, 27 Jul 2021 11:47:06 -0400 Received: from pps.filterd (m0148461.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16RFiRol006191; Tue, 27 Jul 2021 08:46:34 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=subject : to : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=facebook; bh=pn5GGVogEhi5odJ9sKw+8sInrHAd/N7e4nJ6L2NkyQg=; b=lQZY4IDO28Dk7OxBtJA3/oofdpOex6CYkosZUdF7PCE+4oi2nynzuyByORR9fKbQACtV Eam0sAQ7tLSs3f2Oy1T3d0tGZ5oy1YfsKY3mX5khJ6reRmxAsG52eCXIQ537zo4S8/VT lMpuLkw075gOnuQjRV7vXhFjo6O0NEvQwm0= Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com with ESMTP id 3a2bfc3d8a-6 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Tue, 27 Jul 2021 08:46:34 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (100.104.31.183) by o365-in.thefacebook.com (100.104.36.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 27 Jul 2021 08:46:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HNKsaLPbv91q1AZFQrZFvmYAAeLda9vISX5+yvQJrcpicsXfCnByKVRU4JWUcoXOGkdfjQpk3b8UY2+fQhgYPj9pdlANrVwY1PEBPYdbS2F2vxFpK6UUg71SYtzi2mUm57SbtCQ/ge5XQxKgtx1omtUbJvoDP1foumCMjU3miGPOV6sMS1X1VuH2O0HrQkrzlqNgadrpb5HAWbs7Q+6OhkA7MhFSVGDfVC9dsq8KJprfNw5XgQLys2flylLbvMET2ptorvdCcVQv/Er4n0i/zHbW5jIfIQHWZ8aM1wJWuEUR4/q6kn7KwofdQbT49Vt0SZwDGhGauWIvRp/U59/Gbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pn5GGVogEhi5odJ9sKw+8sInrHAd/N7e4nJ6L2NkyQg=; b=XBGoHGZpdEEqrqtCenPPl4pp0Pw7RFvVdRIHwVXq3cjzRriJt9euE4zNuAYnGFvc1JAYo9SqnZzR01VwuODg4P4qKTwo7zA/C0AcvHRpzisX7QYAAIcoEy0HQm3lvrQO4UfSBqaj+uh9mnkrVx+PturVRQX4+WsZzWOIhBlZC0ILQqZdu84J0QYRNAJNQKezB0UIXFK7ryU/AKTX/2mNtCj+OUj0rJvcCHQXD5kqX52hqv/zEBx9Qovn5NF7/jkg/OefgH/W8lN25zT/BJdzoZiCBHTHWmRLjoQ8oq2EuviGeh6UB7pW0rghk1fi9vmupc+UjDuh2S13l3zOdnwZ5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fb.com; dmarc=pass action=none header.from=fb.com; dkim=pass header.d=fb.com; arc=none Authentication-Results: sartura.hr; dkim=none (message not signed) header.d=none;sartura.hr; dmarc=none action=none header.from=fb.com; Received: from SN6PR1501MB2064.namprd15.prod.outlook.com (2603:10b6:805:d::27) by SN7PR15MB4176.namprd15.prod.outlook.com (2603:10b6:806:10c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.17; Tue, 27 Jul 2021 15:46:27 +0000 Received: from SN6PR1501MB2064.namprd15.prod.outlook.com ([fe80::c143:fac2:85b4:14cb]) by SN6PR1501MB2064.namprd15.prod.outlook.com ([fe80::c143:fac2:85b4:14cb%7]) with mapi id 15.20.4352.031; Tue, 27 Jul 2021 15:46:27 +0000 Subject: Re: [PATCH 1/3] arm: include: asm: swab: mask rev16 instruction for clang To: Pavo Banicevic , , , , , , , , , , , , , , , , , , , , , , , References: <20210727141119.19812-1-pavo.banicevic@sartura.hr> <20210727141119.19812-2-pavo.banicevic@sartura.hr> From: Yonghong Song Message-ID: <424add3f-d79a-79dd-2e6a-dbb966bf7349@fb.com> Date: Tue, 27 Jul 2021 08:46:23 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 In-Reply-To: <20210727141119.19812-2-pavo.banicevic@sartura.hr> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR03CA0257.namprd03.prod.outlook.com (2603:10b6:a03:3a0::22) To SN6PR1501MB2064.namprd15.prod.outlook.com (2603:10b6:805:d::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2620:10d:c085:21c8::1398] (2620:10d:c090:400::5:4698) by SJ0PR03CA0257.namprd03.prod.outlook.com (2603:10b6:a03:3a0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.26 via Frontend Transport; Tue, 27 Jul 2021 15:46:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ed5593dd-066b-41f8-5ad6-08d95115b1c4 X-MS-TrafficTypeDiagnostic: SN7PR15MB4176: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-FB-Source: Internal X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NlPjqn1lJQBv7831THrxCOxijGP98oiPWbHatTiWQlY4k+RlaKFNrlLUXpng65+Szhj5XjWSU/LxaAV6YVudxL+N+E0nhd5nC7ZLwEIbwa2MZ7NIVGaw8k5Xu+sia31ccoir5sGZ1Ab6MZIhswoVHfWqRkK3ntan4r3mNZMBvL9L69ojgR7+EDpsPrOSoGCbl62v9biZuQ9BNPkI7ZVk04uYQIVLiMZdhldzpookoDOCkfqa7A4+Imfh5aXXxVOjti2Er+0vgHvzpnimdrDH76ZK8G9jOASTcRe1YAcWs93sLFqCIwWJuNLOtVZHtWzG1bodoT9G8nRnuY6dRziEgxV53SGTxQ4ckcAJWhIR63KT8Zm6rTcQHqPDlaG7EkbJC9z36FbrCjvuPp6FBRtEJPKxsdMRHu/tQ1A5fDhxL/aFAILie0mGXNKboHrPURbeV7gDKen9V5b52j7/Nx8NUYCeXUzZ9S7JgKE2P7tJuRTBZy8+TYbzMKAkg+4bssLD1rNbdIjMwFHt6r9WpwRY74rZFv7mZOqfEJ/ObMUJJveSCvCUWNwhiTRowuUVQqWH9bOmt5IKIUudvQ4x1Rco0p2en0msi65Lz0+sN9oUXGPakdBaTf1Iqbk/FBx8d2yP5b7ykwzPq/EC9nq3LPQLRe877HxREay+DFbuLbYT6OI1bIwC0uyB8XqGTbQ4nGPqBz/vDHpEqC2ki+AgSwRwS1yViM7sr/bwG5p4ksDVPsXy3CoRiMEh/ikIe8P8cWvP X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR1501MB2064.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(346002)(376002)(136003)(39860400002)(2616005)(36756003)(53546011)(2906002)(86362001)(6486002)(186003)(8676002)(478600001)(66946007)(66476007)(52116002)(66556008)(8936002)(7416002)(921005)(31686004)(31696002)(5660300002)(38100700002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MCtJeUluc3JzTmp4K1RyNTU3V1R5RHUwOUtmZkF4UGYzcUNRWkoyL1JtdjlC?= =?utf-8?B?Q2tucnFzZmdwdElJZERub0pjQnJTS1lqc0EyUnZtb3Y1R1hBcEFlZUUzNTVh?= =?utf-8?B?UU5Sb2J6NzZrUEFzZzRvdG8zTDVTSTdkeVJ0V2tDN21IVjVBZDlBd0NBVlJq?= =?utf-8?B?ZzJIbWtSMityQ1ZZKzBQSEs3QnZldVlTSkNYM2kyMG0xdlRnbmVMdFVheEFu?= =?utf-8?B?b2I2cTVNLzgzdU02U2pKb0RsR3dtUGVCUEp4RFRsSDdkWUlVWWRtb0k2b0NX?= =?utf-8?B?cXp5TzZUQVhnNDhoaldCSXUwS0xGaGdxZEE5bnI2Y3o3bjQ3UkxMbmE5aEk1?= =?utf-8?B?allkY0dzbXdNRlphTXBBTnVJbGp0Yy9Zd1FUT3NnTHZFaDMzNW5IMTdxMTYy?= =?utf-8?B?bk1aRmFKMzgwM1orNVpGay9DRFJGcHgxbmRXOUgyUzF6d0ZGWGMrT2JaS25O?= =?utf-8?B?Q2JOdFJURUp4Y3JTclYrZnVjYjBFbzlYNlB5dy9mcmZHb2RsMkpUQUY0VHBQ?= =?utf-8?B?NjdkS2JaeVZoUVhZdS90eCtQSmlGbGxmWGhVK0hFbXJoV215RDFxZWF6Z0xo?= =?utf-8?B?eUVCUFRwZ3lXTnJyV1FyUmxYdDhubTlORk1IcjVVNEFndjRQc0lCNjliczZP?= =?utf-8?B?MWxXTkUyaTRRTnFabDJFZXd3M24zU2NFSjA5NXNtWWhIUmpPTFhGUnRzQm5V?= =?utf-8?B?R1k2TmJZenM3WUg0YlJaTGxHZVVpY0lXWEpGQ2xWUTBTL3V0N1VxeGVCemQ2?= =?utf-8?B?ZGI1KzNqTnhTRWVCbVRQZVVTdEkzN2ZKcm13RlYzcGMzaTZ3MmpSQklMNmRM?= =?utf-8?B?dHpRUDE4V2dkczNGeU1ZSFJhVzNBT1E4VlpDaEY5b3I3U2hFaFhhVkRrYzho?= =?utf-8?B?UWtVbUNEVVRvVWpYTGNaMjBrU1RqSWxPNlFPQklTOFprWTNURVo4RHJqOSsx?= =?utf-8?B?Q3RjTXBIYkcwSEtPc1RERVNYdkFWZjN0UjZLcFpGWEc2NkVNdVZIeEw4NGlt?= =?utf-8?B?WVAxeXp5ZE9SWVdQQUw3T3pXU0RJekNLNS8vY1hwL25nYVJ6ZVFieU1tNnpr?= =?utf-8?B?YmVNN1ppQjZLQXF3Wit3VHZPTUNJdkI4SW9Sd25JanVjU2ZpbFlieDZaQWpn?= =?utf-8?B?MTVPWGJkQnE1eER2Y1JEV3AyWXNZV0c4eU81RG9yUHo1QnBtVU44TDdocmdr?= =?utf-8?B?VDNmeTh6YmpleEFsT0toUVM2MW5mZ2U0UlBYeWVYSEZ4djRyVGwrQ2FocTBB?= =?utf-8?B?aFNMNFlROUNaRTVIVjY5TEhRdC9hL0t5SnRsRmVuVkQxU3p5bDdoNFFZd2RT?= =?utf-8?B?QmdKZVZkdThvMExFcHE4cHpjMGFaZ0lLckw3Zk9ZOHFRZDJOdFpFUS9mUkpD?= =?utf-8?B?Wnd0dDA5eG5QMlpvMVdGZEFuS04weXYwT3NrRnNLRlpOdnJldUplNlNrcHRi?= =?utf-8?B?K3F2dlp0QVBFVlp4T1VsMDdsbCthbkZXWFd1VjVSWVBCZWpGOWZHYlowQytZ?= =?utf-8?B?bTRyM3hxODA4eDVjN2hKZG1EZ3RsWEJzSFdqOUx4Y2wxMmdCUWlrT3A4bWZ3?= =?utf-8?B?cytRenNWaTZyTWJZWmdSYVVzY1NqTm56OWhIWGk2TGhhMktOd3VYUm4wcDAx?= =?utf-8?B?eXZqU3RCeG92QkRlMlplbzU4UStJN3V5cjlLdExVYU9TbXZhd252YnRGU2tN?= =?utf-8?B?SUFNREtJbVQreUdHa0VhZkxHb2ppVkpTT2drQTF5MmhuVGpaQVpMWlVaK0JO?= =?utf-8?B?bnNzOHBYSHZSUXVWVWZlMFJBbzc2Y3doallmQzlMWUQwem5Va2RuN01xeCtl?= =?utf-8?B?U2dmSTAxcDM0Y1UwTytvQT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: ed5593dd-066b-41f8-5ad6-08d95115b1c4 X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2021 15:46:26.9993 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1kFwau23EySKr4z1jFZY+IKsypC3+MADhunEWMNRM1hKrZX2vPVrmhyGTNgKZr30 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR15MB4176 X-OriginatorOrg: fb.com X-Proofpoint-GUID: pe_1I5CukfauFBJHpx04hDyv0lUAcAgo X-Proofpoint-ORIG-GUID: pe_1I5CukfauFBJHpx04hDyv0lUAcAgo X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-07-27_10:2021-07-27,2021-07-27 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxlogscore=999 malwarescore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1011 mlxscore=0 bulkscore=0 spamscore=0 suspectscore=0 priorityscore=1501 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2107270094 X-FB-Internal: deliver Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/27/21 7:11 AM, Pavo Banicevic wrote: > From: Ivan Khoronzhuk > > The samples/bpf with clang -emit-llvm reuses linux headers to build > bpf samples, and this w/a only for samples (samples/bpf/Makefile > CLANG-bpf). > > It allows to build samples/bpf for arm bpf using clang. > In another way clang -emit-llvm generates errors like: > > CLANG-bpf samples/bpf/tc_l2_redirect_kern.o > :1:2: error: invalid register/token name > rev16 r3, r0 > > This decision is arguable, probably there is another way, but > it doesn't have impact on samples/bpf, so it's easier just ignore > it for clang, at least for now. > > Signed-off-by: Ivan Khoronzhuk > --- > arch/arm/include/asm/swab.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/include/asm/swab.h b/arch/arm/include/asm/swab.h > index c6051823048b..a9fd9cd33d5e 100644 > --- a/arch/arm/include/asm/swab.h > +++ b/arch/arm/include/asm/swab.h > @@ -25,8 +25,11 @@ static inline __attribute_const__ __u32 __arch_swahb32(__u32 x) > __asm__ ("rev16 %0, %1" : "=r" (x) : "r" (x)); > return x; > } > + > +#ifndef __clang__ > #define __arch_swahb32 __arch_swahb32 > #define __arch_swab16(x) ((__u16)__arch_swahb32(x)) > +#endif What if the kernel is compiled with clang compiler? Does this still work? To workaround samples/bpf issue, I think you can use __BPF_TRACING__ macro. > > static inline __attribute_const__ __u32 __arch_swab32(__u32 x) > { >