From: Frank Rowand <frowand.list@gmail.com>
To: Rob Herring <robh@kernel.org>, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: Add device_type access helper functions
Date: Tue, 4 Sep 2018 20:55:48 -0700 [thread overview]
Message-ID: <4253073f-5ddf-a01c-4d3e-5c6a13068903@gmail.com> (raw)
In-Reply-To: <20180830185229.20393-1-robh@kernel.org>
On 08/30/18 11:52, Rob Herring wrote:
> In preparation to remove direct access to device_node.type, add
> of_node_is_type() and of_node_get_device_type() helpers to check and
> retrieve the device type.
>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> include/linux/of.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/include/linux/of.h b/include/linux/of.h
> index a40f63a36afa..506beca9588d 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -980,6 +980,18 @@ static inline struct device_node *of_find_matching_node(
> return of_find_matching_node_and_match(from, matches, NULL);
> }
>
> +static inline const char *of_node_get_device_type(const struct device_node *np)
> +{
> + return of_get_property(np, "type", NULL);
I'm a little confused. The patch comment says "remove direct access to device_node.type.
device_node.type is set to the value of the property "device_type" in populate_node(),
but of_node_get_device_type() is looking for property "type".
> +}> +
> +static inline bool of_node_is_type(const struct device_node *np, const char *type)
> +{
> + const char *match = of_node_get_device_type(np);
> +
> + return np && match && type && !of_prop_cmp(match, type);
> +}
> +
> /**
> * of_property_count_u8_elems - Count the number of u8 elements in a property
> *
>
I'd like to see one or two examples of how you plan to use of_node_get_device_type()
(outside of of_node_is_type()) and examples of planned use of of_node_is_type() so
I can better understand anticipated usage. Complete, clean patches not needed for
the examples, just enough text for me to see the resulting code change where the
helpers are used.
-Frank
next prev parent reply other threads:[~2018-09-05 3:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 18:52 [PATCH] of: Add device_type access helper functions Rob Herring
2018-09-05 3:55 ` Frank Rowand [this message]
2018-09-05 13:17 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4253073f-5ddf-a01c-4d3e-5c6a13068903@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).