From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
Eric Biggers <ebiggers@kernel.org>,
"Theodore Y. Ts o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Jonathan Corbet <corbet@lwn.net>, Jens Axboe <axboe@kernel.dk>,
Ard Biesheuvel <ardb@kernel.org>,
linux-fscrypt@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v3 1/2] blk-crypto: Add support for SM4-XTS blk crypto mode
Date: Mon, 28 Nov 2022 20:26:38 +0700 [thread overview]
Message-ID: <42624542-6ccb-26a5-db98-d7944972246e@gmail.com> (raw)
In-Reply-To: <20221125121630.87793-2-tianjia.zhang@linux.alibaba.com>
On 11/25/22 19:16, Tianjia Zhang wrote:
> SM4 is a symmetric algorithm widely used in China, and SM4-XTS is also
> used to encrypt length-preserving data, these algoritms are mandatory
> in many scenarios. This patch enables the use of SM4-XTS algorithm in
> block inline encryption, and provides support for fscrypt.
>
Please reformulate the patch description in imperative mood instead.
Also, take care of wording and punctuation - commas should not be
used for continuing distinct sentences/clauses where separating them
by a full stop is more appropriate.
That is, the description should be:
```
SM4 is a symmetric cipher algorithm widely used in China. The SM4-XTS
variant is used to encrypt length-preserving data.
Enable the algorithm in block inline encryption, as well as enable
fscrypt support.
```
Thanks.
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2022-11-28 13:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 12:16 [PATCH v3 0/2] Add SM4 XTS symmetric algorithm for blk-crypto and fscrypt Tianjia Zhang
2022-11-25 12:16 ` [PATCH v3 1/2] blk-crypto: Add support for SM4-XTS blk crypto mode Tianjia Zhang
2022-11-25 18:35 ` Eric Biggers
2022-11-25 18:37 ` Jens Axboe
2022-11-28 13:26 ` Bagas Sanjaya [this message]
2022-11-25 12:16 ` [PATCH v3 2/2] fscrypt: Add SM4 XTS/CTS symmetric algorithm support Tianjia Zhang
2022-11-25 18:24 ` Eric Biggers
2022-11-28 7:35 ` Tianjia Zhang
2022-11-28 13:33 ` Bagas Sanjaya
2022-12-01 12:45 ` Tianjia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42624542-6ccb-26a5-db98-d7944972246e@gmail.com \
--to=bagasdotme@gmail.com \
--cc=ardb@kernel.org \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).