From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752021Ab2GSVXK (ORCPT ); Thu, 19 Jul 2012 17:23:10 -0400 Received: from ch1ehsobe001.messaging.microsoft.com ([216.32.181.181]:29462 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751466Ab2GSVXG convert rfc822-to-8bit (ORCPT ); Thu, 19 Jul 2012 17:23:06 -0400 X-Forefront-Antispam-Report: CIP:131.107.125.8;KIP:(null);UIP:(null);IPV:NLI;H:TK5EX14HUBC107.redmond.corp.microsoft.com;RD:none;EFVD:NLI X-SpamScore: -10 X-BigFish: VS-10(zzbb2dI98dI9371I148cI542M1432Izz1202hzz8275dhz2fh2a8h683h839h944hd25hf0ah107ah) X-Forefront-Antispam-Report-Untrusted: CIP:157.56.234.5;KIP:(null);UIP:(null);(null);H:SN2PRD0310HT003.namprd03.prod.outlook.com;R:internal;EFV:INT From: KY Srinivasan To: "Greg KH (gregkh@linuxfoundation.org)" CC: Paolo Bonzini , "devel@linuxdriverproject.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.osdl.org" Subject: RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) Thread-Topic: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) Thread-Index: AQHNYOGVQIU8WaEGMU+rzjsXSQqoHZcv427wgAE/uYCAAABWIA== Date: Thu, 19 Jul 2012 21:22:53 +0000 Message-ID: <426367E2313C2449837CD2DE46E7EAF9235475EE@SN2PRD0310MB382.namprd03.prod.outlook.com> References: <1316708240-25048-1-git-send-email-kys@microsoft.com> <20110922170450.GA4490@suse.de> <6E21E5352C11B742B20C142EB499E048081E935D@TK5EX14MBXC124.redmond.corp.microsoft.com> <20110922173618.GA5624@suse.de> <6E21E5352C11B742B20C142EB499E048081EB789@TK5EX14MBXC124.redmond.corp.microsoft.com> <20111004170415.GA1320@suse.de> <6E21E5352C11B742B20C142EB499E048081EB86F@TK5EX14MBXC124.redmond.corp.microsoft.com> <20111004193414.GA15672@suse.de> <4FFFF711.8040003@redhat.com> <426367E2313C2449837CD2DE46E7EAF923547292@SN2PRD0310MB382.namprd03.prod.outlook.com> <20120719210709.GA32031@kroah.com> In-Reply-To: <20120719210709.GA32031@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [108.24.39.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OrganizationHeadersPreserved: SN2PRD0310HT003.namprd03.prod.outlook.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% X-FOPE-CONNECTOR: Id%59$Dn%LINUXFOUNDATION.ORG$RO%2$TLS%6$FQDN%131.107.125.5$TlsDn% X-FOPE-CONNECTOR: Id%59$Dn%REDHAT.COM$RO%2$TLS%6$FQDN%131.107.125.5$TlsDn% X-FOPE-CONNECTOR: Id%59$Dn%LINUXDRIVERPROJECT.ORG$RO%2$TLS%6$FQDN%131.107.125.5$TlsDn% X-FOPE-CONNECTOR: Id%59$Dn%VGER.KERNEL.ORG$RO%2$TLS%6$FQDN%131.107.125.5$TlsDn% X-FOPE-CONNECTOR: Id%59$Dn%LISTS.OSDL.ORG$RO%2$TLS%6$FQDN%131.107.125.5$TlsDn% X-CrossPremisesHeadersPromoted: TK5EX14HUBC107.redmond.corp.microsoft.com X-CrossPremisesHeadersFiltered: TK5EX14HUBC107.redmond.corp.microsoft.com X-OriginatorOrg: microsoft.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Greg KH (gregkh@linuxfoundation.org) > [mailto:gregkh@linuxfoundation.org] > Sent: Thursday, July 19, 2012 5:07 PM > To: KY Srinivasan > Cc: Paolo Bonzini; devel@linuxdriverproject.org; linux-kernel@vger.kernel.org; > virtualization@lists.osdl.org > Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the > drivers/staging/ directory) > > On Thu, Jul 19, 2012 at 02:11:47AM +0000, KY Srinivasan wrote: > > > > > > > -----Original Message----- > > > From: Paolo Bonzini [mailto:paolo.bonzini@gmail.com] On Behalf Of Paolo > > > Bonzini > > > Sent: Friday, July 13, 2012 6:23 AM > > > To: KY Srinivasan > > > Cc: Greg KH; devel@linuxdriverproject.org; linux-kernel@vger.kernel.org; > > > virtualization@lists.osdl.org > > > Subject: 0xB16B00B5? Really? (was Re: Move hyperv out of the > drivers/staging/ > > > directory) > > > > > > Il 04/10/2011 21:34, Greg KH ha scritto: > > > > diff --git a/drivers/staging/hv/hyperv_vmbus.h > b/drivers/hv/hyperv_vmbus.h > > > > similarity index 99% > > > > rename from drivers/staging/hv/hyperv_vmbus.h > > > > rename to drivers/hv/hyperv_vmbus.h > > > > index 3d2d836..8261cb6 100644 > > > > --- a/drivers/staging/hv/hyperv_vmbus.h > > > > +++ b/drivers/hv/hyperv_vmbus.h > > > > @@ -28,8 +28,7 @@ > > > > #include > > > > #include > > > > #include > > > > - > > > > -#include "hyperv.h" > > > > +#include > > > > > > > > /* > > > > * The below CPUID leaves are present if > > > VersionAndFeatures.HypervisorPresent > > > > > > git's rename detection snips away this gem: > > > > > > +#define HV_LINUX_GUEST_ID_LO 0x00000000 > > > +#define HV_LINUX_GUEST_ID_HI 0xB16B00B5 > > > +#define HV_LINUX_GUEST_ID (((u64)HV_LINUX_GUEST_ID_HI > > > << 32) | \ > > > + HV_LINUX_GUEST_ID_LO) > > > > > > Somone was trying to be funny, I guess. > > > > > > KY, I suppose you have access to Hyper-V code or can ask someone who > does. > > > Is this signature actually used in the Hyper-V host code? > > > > Paolo, > > > > As I noted earlier, this is just a guest ID that needs to be registered with the > > hypervisor. Thanks for reporting this issue and on behalf of Microsoft, I would > > like to apologize for this offensive string. I have submitted a patch to fix this > issue. > > You only changed it to be in decimal, you did not change the id at all. > Is there some reason why you can not change it? You said there was a > reserved range of ids that could be used, perhaps just pick another one? > What is the valid range that can be used here? Greg, As you know, this ID has been in use for a long time now. While the hypervisor does not interpret the guest ID that is registered, I am not sure what dependencies there might be on this value. That is the reason I am reluctant to change the value. Since the hex representation of this constant was what was offensive, changing it to a decimal number would not break anything while simultaneously addressing the issue Paolo brought up. Regards, K. Y