From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753770Ab2IECZl (ORCPT ); Tue, 4 Sep 2012 22:25:41 -0400 Received: from va3ehsobe006.messaging.microsoft.com ([216.32.180.16]:22755 "EHLO va3outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751258Ab2IECZk convert rfc822-to-8bit (ORCPT ); Tue, 4 Sep 2012 22:25:40 -0400 X-Forefront-Antispam-Report: CIP:131.107.125.8;KIP:(null);UIP:(null);IPV:NLI;H:TK5EX14HUBC101.redmond.corp.microsoft.com;RD:none;EFVD:NLI X-SpamScore: -8 X-BigFish: VS-8(zz98dI9371I542M1432Izz1202hzz8275bh8275dhz2fh2a8h683h839h944hd25hf0ah107ah1220h1155h) X-Forefront-Antispam-Report-Untrusted: CIP:157.56.234.5;KIP:(null);UIP:(null);(null);H:SN2PRD0310HT002.namprd03.prod.outlook.com;R:internal;EFV:INT From: KY Srinivasan To: KY Srinivasan , Greg KH CC: "olaf@aepfle.de" , "thozza@redhat.com" , "linux-kernel@vger.kernel.org" , "dcbw@redhat.com" , "apw@canonical.com" , "devel@linuxdriverproject.org" , "ben@decadent.org.uk" Subject: RE: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve dhcp state Thread-Topic: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve dhcp state Thread-Index: AQHNiuRd+TMU4+nMkkGvTOIPJ1HKHZd6zAmAgAAKcsCAAAe5gIAABXKggAAhcrA= Date: Wed, 5 Sep 2012 02:25:28 +0000 Message-ID: <426367E2313C2449837CD2DE46E7EAF9309E007C@SN2PRD0310MB382.namprd03.prod.outlook.com> References: <1346795156-25614-1-git-send-email-kys@microsoft.com> <1346795202-25655-1-git-send-email-kys@microsoft.com> <1346795202-25655-5-git-send-email-kys@microsoft.com> <20120904225917.GB3725@kroah.com> <426367E2313C2449837CD2DE46E7EAF9309DFFA2@SN2PRD0310MB382.namprd03.prod.outlook.com> <20120905000419.GC31997@kroah.com> <426367E2313C2449837CD2DE46E7EAF9309DFFBE@SN2PRD0310MB382.namprd03.prod.outlook.com> In-Reply-To: <426367E2313C2449837CD2DE46E7EAF9309DFFBE@SN2PRD0310MB382.namprd03.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [173.61.55.165] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OrganizationHeadersPreserved: SN2PRD0310HT002.namprd03.prod.outlook.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% X-FOPE-CONNECTOR: Id%59$Dn%LINUXFOUNDATION.ORG$RO%2$TLS%6$FQDN%131.107.125.5$TlsDn% X-FOPE-CONNECTOR: Id%59$Dn%AEPFLE.DE$RO%2$TLS%6$FQDN%131.107.125.5$TlsDn% X-FOPE-CONNECTOR: Id%59$Dn%REDHAT.COM$RO%2$TLS%6$FQDN%131.107.125.5$TlsDn% X-FOPE-CONNECTOR: Id%59$Dn%VGER.KERNEL.ORG$RO%2$TLS%6$FQDN%131.107.125.5$TlsDn% X-FOPE-CONNECTOR: Id%59$Dn%CANONICAL.COM$RO%2$TLS%6$FQDN%131.107.125.5$TlsDn% X-FOPE-CONNECTOR: Id%59$Dn%LINUXDRIVERPROJECT.ORG$RO%2$TLS%6$FQDN%131.107.125.5$TlsDn% X-FOPE-CONNECTOR: Id%59$Dn%DECADENT.ORG.UK$RO%2$TLS%6$FQDN%131.107.125.5$TlsDn% X-CrossPremisesHeadersPromoted: TK5EX14HUBC101.redmond.corp.microsoft.com X-CrossPremisesHeadersFiltered: TK5EX14HUBC101.redmond.corp.microsoft.com X-OriginatorOrg: microsoft.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: devel [mailto:devel-bounces@linuxdriverproject.org] On Behalf Of KY > Srinivasan > Sent: Tuesday, September 04, 2012 8:29 PM > To: Greg KH > Cc: olaf@aepfle.de; thozza@redhat.com; linux-kernel@vger.kernel.org; > dcbw@redhat.com; apw@canonical.com; devel@linuxdriverproject.org; > ben@decadent.org.uk > Subject: RE: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve dhcp > state > > > > > -----Original Message----- > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > Sent: Tuesday, September 04, 2012 8:04 PM > > To: KY Srinivasan > > Cc: olaf@aepfle.de; thozza@redhat.com; linux-kernel@vger.kernel.org; > > dcbw@redhat.com; apw@canonical.com; devel@linuxdriverproject.org; > > ben@decadent.org.uk > > Subject: Re: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve dhcp > > state > > > > On Tue, Sep 04, 2012 at 11:39:12PM +0000, KY Srinivasan wrote: > > > > > > > > > > -----Original Message----- > > > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > > > Sent: Tuesday, September 04, 2012 6:59 PM > > > > To: KY Srinivasan > > > > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; > > olaf@aepfle.de; > > > > apw@canonical.com; ben@decadent.org.uk; thozza@redhat.com; > > > > dcbw@redhat.com > > > > Subject: Re: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve > > dhcp > > > > state > > > > > > > > On Tue, Sep 04, 2012 at 02:46:37PM -0700, K. Y. Srinivasan wrote: > > > > > To keep the KVP daemon code free of distro specific details, we invoke an > > > > > external script to retrieve the DHCP state. This is an example script that > > > > > was used to test the KVP code. This script has to be implemented in a > Distro > > > > > specific fashion. For instance on distros that ship with Network Manager > > > > enabled, > > > > > this script can be based on NM APIs. > > > > > > > > > > Signed-off-by: K. Y. Srinivasan > > > > > Reviewed-by: Haiyang Zhang > > > > > --- > > > > > tools/hv/hv_get_dhcp_info.sh | 25 +++++++++++++++++++++++++ > > > > > 1 files changed, 25 insertions(+), 0 deletions(-) > > > > > create mode 100755 tools/hv/hv_get_dhcp_info.sh > > > > > > > > > > diff --git a/tools/hv/hv_get_dhcp_info.sh > b/tools/hv/hv_get_dhcp_info.sh > > > > > new file mode 100755 > > > > > index 0000000..3de4587 > > > > > --- /dev/null > > > > > +++ b/tools/hv/hv_get_dhcp_info.sh > > > > > @@ -0,0 +1,25 @@ > > > > > +#!/bin/bash > > > > > + > > > > > +# This example script retrieves the DHCP state of a given interface. > > > > > +# In the interest of keeping the KVP daemon code free of distro specific > > > > > +# information; the kvp daemon code invokes this external script to > gather > > > > > +# DHCP setting for the specific interface. > > > > > +# > > > > > +# Input: Name of the interface > > > > > +# > > > > > +# Output: The script prints the string "Enabled" to stdout to indicate > > > > > +# that DHCP is enabled on the interface. > > > > > > > > What happens if DHCP is not enabled on the interface? Shouldn't that > > > > also return something other than "success"? > > > > > > The script is expected to write "Enabled" to stdout to indicate if DHCP is > > enabled; if this > > > is not the case, implicitly we assume DHCP is not enabled (since this is a binary > > state). > > > > It's not really "binary" given that you are expecting "Enabled" or > > nothing, right? "Disabled" would make a bit more sense perhaps? > > In the KVP daemon code, I currently only check for "Enabled" to see if > DHCP is enabled. > > > > > Having a script return "nothing at all" to show the failure of a state > > doesn't seem the wisest thing, does it? > > I can certainly resubmit this patch with the change you are suggesting. This patch > adds a new file > and does not impact any of the other patches that follows this. Would you want > me to resubmit all of the > remaining patches starting with this one. I have resent this patch with the change you have suggested. Since this patch is a standalone patch I have not resent the other patches that follow this patch. Let me know if you want me to resend the remaining patches. Regards, K. Y > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/devel > >