From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425665AbdD2Bnq (ORCPT ); Fri, 28 Apr 2017 21:43:46 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:36006 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1164635AbdD2Bnj (ORCPT ); Fri, 28 Apr 2017 21:43:39 -0400 From: Geliang Tang To: Ivan Hu , Matt Fleming , Ard Biesheuvel Cc: Geliang Tang , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] efi/efi_test: drop useless kfree Date: Sat, 29 Apr 2017 09:42:53 +0800 Message-Id: <427b03b5f10b41014818b9e78f79da9581b213df.1493383416.git.geliangtang@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Drop useless kfree when memdup_user() failed, since we have already called kfree in memdup_user(). Signed-off-by: Geliang Tang --- drivers/firmware/efi/test/efi_test.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/firmware/efi/test/efi_test.c b/drivers/firmware/efi/test/efi_test.c index 08129b7..00332ae 100644 --- a/drivers/firmware/efi/test/efi_test.c +++ b/drivers/firmware/efi/test/efi_test.c @@ -261,10 +261,8 @@ static long efi_runtime_set_variable(unsigned long arg) } data = memdup_user(setvariable.data, setvariable.data_size); - if (IS_ERR(data)) { - kfree(name); + if (IS_ERR(data)) return PTR_ERR(data); - } status = efi.set_variable(name, &vendor_guid, setvariable.attributes, -- 2.9.3