From: John David Anglin <dave.anglin@bell.net>
To: Helge Deller <deller@gmx.de>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-parisc@vger.kernel.org, kbuild-all@lists.01.org,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, Kees Cook <keescook@chromium.org>,
kernel test robot <lkp@intel.com>
Subject: Re: hppa64-linux-ld: mm/hugetlb.o(.text+0x50dc): cannot reach printk
Date: Mon, 25 Jan 2021 16:17:50 -0500 [thread overview]
Message-ID: <428d571c-1f68-7a59-3232-9bb362b51a5b@bell.net> (raw)
In-Reply-To: <3564bcea-5781-123f-564e-53289967e9e4@gmx.de>
On 2021-01-25 4:13 p.m., Helge Deller wrote:
> On 1/25/21 10:08 PM, John David Anglin wrote:
>> I would suggest the following for this hunk:
>>
>> + ldil L%intr_restore, %r2
>> + BL preempt_schedule_irq
>> + ldo R%intr_restore(%r2), %r2
>>
>> ldil L%intr_restore, %r1
>> b,l preempt_schedule_irq,%r2
>> ldo R%intr_restore(%r1), %r2
>>
>> On PA 2.0 hardware that gives a 22-bit call.
> "BL" is already using "b,l", see #define in arch/parisc/include/asm/assembly.h
>
> The 22-bit weren't sufficient, that's why I changed it too.
Okay but "b,l" only provides a 22-bit branch with %r2 as link register. You also need to use %r1 in the ldil and ldo instructions.
Dave
--
John David Anglin dave.anglin@bell.net
next prev parent reply other threads:[~2021-01-25 21:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 14:36 hppa64-linux-ld: mm/hugetlb.o(.text+0x50dc): cannot reach printk kernel test robot
2021-01-25 17:54 ` Nick Desaulniers
2021-01-25 18:34 ` John David Anglin
2021-01-25 19:25 ` Helge Deller
2021-01-25 20:47 ` Helge Deller
2021-01-25 20:58 ` Nick Desaulniers
2021-01-25 21:05 ` Helge Deller
2021-01-25 20:59 ` Helge Deller
2021-01-25 21:08 ` John David Anglin
2021-01-25 21:13 ` Helge Deller
2021-01-25 21:17 ` John David Anglin [this message]
2021-01-25 21:37 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=428d571c-1f68-7a59-3232-9bb362b51a5b@bell.net \
--to=dave.anglin@bell.net \
--cc=James.Bottomley@hansenpartnership.com \
--cc=deller@gmx.de \
--cc=kbuild-all@lists.01.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).