From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751820AbcGPTLq (ORCPT <rfc822;w@1wt.eu>);
	Sat, 16 Jul 2016 15:11:46 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:49474 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751685AbcGPTLn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 16 Jul 2016 15:11:43 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Jamie Lentin <jm@lentin.co.uk>, Jason Cooper <jason@lakedaemon.net>,
        Andrew Lunn <andrew@lunn.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Gregory Clement <gregory.clement@free-electrons.com>,
        Imre Kaloz <kaloz@openwrt.org>,
        Florian Fainelli <f.fainelli@gmail.com>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v0 06/10] arm: orion5x: Add DT-based support for Netgear WNR854T
Date: Sat, 16 Jul 2016 21:10:38 +0200
Message-ID: <4290281.AD5Bhg23o6@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-28-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1468679348-10522-7-git-send-email-jm@lentin.co.uk>
References: <1468679348-10522-1-git-send-email-jm@lentin.co.uk> <1468679348-10522-7-git-send-email-jm@lentin.co.uk>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:6xwKoj4c7Tk/WLYeiwgRk4wYorvFyUxvct1rFtkRTjAcKeN7b2j
 n0o7r51CtLveNM2FGPPXqZ4Lp3g8CUsXyPbig6wl+7Df5eI06G/oxCCVwkdGczHbu9bgkpT
 PQDjNauRreFZH6D8Fj3dbZHggTbmtqM8z8tkdFrvuzMyq1SAigiVpfDj/LKf8gxiBL7meWC
 V7kc5qJwn6nqVugsRPgYA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:TeldxGfUtIw=:sIpTA/M15Y7PjASQIcqSxt
 KF74cKOV6YCqE+sVsBWXgVrnzdqxoO+mKs56TbbRegk4BF2HxjOFYDTqKPiPsZXhBXLLEpC4Y
 bhtlb8lpaPVUwYlGPKS1VGO70aK8m5owPpprRnyEHN2l0MxEeCD8N/xV05GTIswgZOYVojNKR
 1lQvMNntyQWteN7IPYQoY6L5rLSs9LJ5w0HYJ8Mv7yQLfb95iUVqYA8O+BcAsu6xj5WJMdp0B
 qkqryH22JPgWm/W5HTiTNM9rPvSp2o10OiSz5eMcQBj23TFfSjBxU3sZdsQJsEHIGkBGQbp7D
 ATV+4Ayvmyjjfl3zUY396Zeve82Gdc5PP9wo+jfgywrJQt5xd9rh8vKq4Tkb9oWQvTBxxT1t0
 HohbuU2SQeFWmAtRnnCCKpN1lQQUKUCF6Rd4SsxeVjExZUi7FK+WW5rWH1InqfGAjg1xI/Yrd
 4wIk1GawsfELg3xu/TtdMcInVXHEPh4Kd5UcyJcUKfswELPpXfk8HJtjdLFivPPyv/Ro8o8nh
 1p5BGINjOPxer/EA6KB56AZ6y7kDaRutEfDXtmdpGTlqGalT0skm6AXJCMDtS+ZVI7BniovUO
 /C1euA4jkmpciB0TgVyPVbYVHjFinBwEhzvk4esIna3kL43L9HM4gw6lBVRJz5ew4bRNLaqxQ
 aKQlv90uSvdgPipCLTyNpMj89SVQ4nWHNcXTrCbSd4DZhwX3b6DwO3IBXtycAR2Mx125The4C
 yp2S9KI5SFbxgkpN
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Saturday, July 16, 2016 3:29:04 PM CEST Jamie Lentin wrote:
> +
> +#define WNR854T_PCI_SLOT0_OFFS	7
> +#define WNR854T_PCI_SLOT0_IRQ_PIN	4
> +
> +static void __init wnr854t_pci_preinit(void)
> +{
> +	int pin;
> +
> +	/*
> +	 * Configure PCI GPIO IRQ pins
> +	 */
> +	pin = WNR854T_PCI_SLOT0_IRQ_PIN;
> +	if (gpio_request(pin, "PCI Int") == 0) {
> +		if (gpio_direction_input(pin) == 0) {
> +			irq_set_irq_type(gpio_to_irq(pin), IRQ_TYPE_LEVEL_LOW);
> +		} else {
> +			pr_err("wnr854t_pci_preinit failed to set_irq_type pin %d\n",
> +				pin);
> +			gpio_free(pin);
> +		}
> +	} else {
> +		pr_err("wnr854t_pci_preinit failed to request gpio %d\n", pin);
> +	}
> +}
> +
> +static int __init wnr854t_pci_map_irq(const struct pci_dev *dev, u8 slot,
> +	u8 pin)
> +{
> +	int irq;
> +
> +	/*
> +	 * Check for devices with hard-wired IRQs.
> +	 */
> +	irq = orion5x_pci_map_irq(dev, slot, pin);
> +	if (irq != -1)
> +		return irq;
> +
> +	/*
> +	 * PCI IRQs are connected via GPIOs
> +	 */
> +	switch (slot - WNR854T_PCI_SLOT0_OFFS) {
> +	case 0:
> +		return gpio_to_irq(WNR854T_PCI_SLOT0_IRQ_PIN);
> +	default:
> +		return -1;
> +	}
> +}

The other patches all appear good to me, but I find this one suspicious.

Why are you not using the device tree for probing PCI? Is there anything
missing in drivers/pci/host/pci-mvebu.c, or do you just need help
describing it in DT?

	Arnd