From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0298AC55179 for ; Thu, 5 Nov 2020 17:06:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EDA020936 for ; Thu, 5 Nov 2020 17:06:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="RMu/nVGk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731602AbgKERGO (ORCPT ); Thu, 5 Nov 2020 12:06:14 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:53570 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbgKERGN (ORCPT ); Thu, 5 Nov 2020 12:06:13 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0A5H6Abp043328; Thu, 5 Nov 2020 11:06:10 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1604595970; bh=4gaKFpK8PJGCAAmmXQzonqFwV4ZrZVTTuRDhDq5Bgls=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=RMu/nVGke+7u/agYvacjXjqt8YpTafjN6PDCl9ZOY0oIUrBc/6w6KawvRKdWAIkzt 5nvkYgZDcqOxMTxaQUgjYtvSovHLALAVDCFr2aMZeTIo3bKFkpUgIRP/Gm3GzJgdZw QDRHNgnt6WpJbijRyrUgC1/w3E8rjjEDAjwL1vG8= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0A5H6Ar6108561 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 5 Nov 2020 11:06:10 -0600 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 5 Nov 2020 11:06:10 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 5 Nov 2020 11:06:10 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0A5H687K073591; Thu, 5 Nov 2020 11:06:09 -0600 Subject: Re: [PATCH 04/19] gpu: drm: omapdrm: omap_irq: Fix a couple of doc-rot issues To: Lee Jones CC: , David Airlie , Daniel Vetter , Rob Clark , References: <20201105144517.1826692-1-lee.jones@linaro.org> <20201105144517.1826692-5-lee.jones@linaro.org> From: Tomi Valkeinen Message-ID: <429684b9-c967-95cf-1d8a-9f5249a00a5d@ti.com> Date: Thu, 5 Nov 2020 19:06:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201105144517.1826692-5-lee.jones@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/2020 16:45, Lee Jones wrote: > The API has been updated, but the header was not. > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/omapdrm/omap_irq.c:115: warning: Function parameter or member 'crtc' not described in 'omap_irq_enable_vblank' > drivers/gpu/drm/omapdrm/omap_irq.c:115: warning: Excess function parameter 'dev' description in 'omap_irq_enable_vblank' > drivers/gpu/drm/omapdrm/omap_irq.c:115: warning: Excess function parameter 'pipe' description in 'omap_irq_enable_vblank' > drivers/gpu/drm/omapdrm/omap_irq.c:142: warning: Function parameter or member 'crtc' not described in 'omap_irq_disable_vblank' > drivers/gpu/drm/omapdrm/omap_irq.c:142: warning: Excess function parameter 'dev' description in 'omap_irq_disable_vblank' > drivers/gpu/drm/omapdrm/omap_irq.c:142: warning: Excess function parameter 'pipe' description in 'omap_irq_disable_vblank' > > Cc: Tomi Valkeinen > Cc: David Airlie > Cc: Daniel Vetter > Cc: Rob Clark > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/omapdrm/omap_irq.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/omap_irq.c b/drivers/gpu/drm/omapdrm/omap_irq.c > index 382bcdc72ac06..8643871e23a83 100644 > --- a/drivers/gpu/drm/omapdrm/omap_irq.c > +++ b/drivers/gpu/drm/omapdrm/omap_irq.c > @@ -100,8 +100,7 @@ int omap_irq_enable_framedone(struct drm_crtc *crtc, bool enable) > > /** > * enable_vblank - enable vblank interrupt events > - * @dev: DRM device > - * @pipe: which irq to enable > + * @crtc: DRM CRTC > * > * Enable vblank interrupts for @crtc. If the device doesn't have > * a hardware vblank counter, this routine should be a no-op, since > @@ -131,8 +130,7 @@ int omap_irq_enable_vblank(struct drm_crtc *crtc) > > /** > * disable_vblank - disable vblank interrupt events > - * @dev: DRM device > - * @pipe: which irq to enable > + * @crtc: DRM CRTC > * > * Disable vblank interrupts for @crtc. If the device doesn't have > * a hardware vblank counter, this routine should be a no-op, since > Hmm, I don't know why we have the doc texts there. These are omapdrm internal functions, and the text sounds like it was copied from a framework function. I think we can drop the texts here. But this patch is fine too, and I can drop the text later: Reviewed-by: Tomi Valkeinen Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki