linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miles Chen <miles.chen@mediatek.com>
To: "Heiko Stübner" <heiko@sntech.de>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>
Cc: <linux-clk@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-rockchip@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>, <wsd_upstream@mediatek.com>
Subject: Re: [PATCH] clk: rockchip: use module_platform_driver_probe
Date: Sat, 4 Sep 2021 23:00:48 +0800	[thread overview]
Message-ID: <42a32455186e5deb476cca74e64de18e8cc1a34c.camel@mediatek.com> (raw)
In-Reply-To: <1764446.vrLGdHa7mH@diego>

On Fri, 2021-09-03 at 22:59 +0200, Heiko Stübner wrote:
> Am Donnerstag, 2. September 2021, 09:57:13 CEST schrieb Miles Chen:
> > Replace builtin_platform_driver_probe with
> > module_platform_driver_probe
> > because that rk3399 and rk3568 can be built as kernel modules.
> > 
> > Cc: Stephen Boyd <sboyd@kernel.org>
> > Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> 
> on both rk3399 and rk3568:
> Tested-by: Heiko Stuebner <heiko@sntech.de>
> 
> and also
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> 

thanks for doing the test. I will add your tags in my next patch.
> 
> Heiko
> 
> > ---
> >  drivers/clk/rockchip/clk-rk3399.c | 2 +-
> >  drivers/clk/rockchip/clk-rk3568.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/clk/rockchip/clk-rk3399.c
> > b/drivers/clk/rockchip/clk-rk3399.c
> > index 62a4f2543960..a5169156f1d2 100644
> > --- a/drivers/clk/rockchip/clk-rk3399.c
> > +++ b/drivers/clk/rockchip/clk-rk3399.c
> > @@ -1653,7 +1653,7 @@ static struct platform_driver
> > clk_rk3399_driver = {
> >  		.suppress_bind_attrs = true,
> >  	},
> >  };
> > -builtin_platform_driver_probe(clk_rk3399_driver,
> > clk_rk3399_probe);
> > +module_platform_driver_probe(clk_rk3399_driver, clk_rk3399_probe);
> >  
> >  MODULE_DESCRIPTION("Rockchip RK3399 Clock Driver");
> >  MODULE_LICENSE("GPL");
> > diff --git a/drivers/clk/rockchip/clk-rk3568.c
> > b/drivers/clk/rockchip/clk-rk3568.c
> > index 75ca855e720d..939e7079c334 100644
> > --- a/drivers/clk/rockchip/clk-rk3568.c
> > +++ b/drivers/clk/rockchip/clk-rk3568.c
> > @@ -1719,7 +1719,7 @@ static struct platform_driver
> > clk_rk3568_driver = {
> >  		.suppress_bind_attrs = true,
> >  	},
> >  };
> > -builtin_platform_driver_probe(clk_rk3568_driver,
> > clk_rk3568_probe);
> > +module_platform_driver_probe(clk_rk3568_driver, clk_rk3568_probe);
> >  
> >  MODULE_DESCRIPTION("Rockchip RK3568 Clock Driver");
> >  MODULE_LICENSE("GPL");
> > 
> 
> 
> 
> 

      reply	other threads:[~2021-09-04 15:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02  7:57 Miles Chen
2021-09-03 18:32 ` Stephen Boyd
2021-09-04 14:59   ` Miles Chen
2021-09-03 20:59 ` Heiko Stübner
2021-09-04 15:00   ` Miles Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42a32455186e5deb476cca74e64de18e8cc1a34c.camel@mediatek.com \
    --to=miles.chen@mediatek.com \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=wsd_upstream@mediatek.com \
    --subject='Re: [PATCH] clk: rockchip: use module_platform_driver_probe' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).