From: "Sa, Nuno" <Nuno.Sa@analog.com>
To: "lukas@wunner.de" <lukas@wunner.de>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"bcm-kernel-feedback-list@broadcom.com"
<bcm-kernel-feedback-list@broadcom.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"kernel@martin.sperl.org" <kernel@martin.sperl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"sbranden@broadcom.com" <sbranden@broadcom.com>,
"wahrenst@gmx.net" <wahrenst@gmx.net>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"linux-rpi-kernel@lists.infradead.org"
<linux-rpi-kernel@lists.infradead.org>,
"eric@anholt.net" <eric@anholt.net>,
"rjui@broadcom.com" <rjui@broadcom.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] spi: spi-bcm2835.c: Fix 3-wire mode
Date: Mon, 1 Jul 2019 14:21:21 +0000 [thread overview]
Message-ID: <42a533cbf1e47ab8c8a44c5e865ec15193a2e956.camel@analog.com> (raw)
In-Reply-To: <20190701115506.42rr4o4hbuvwytjc@wunner.de>
On Mon, 2019-07-01 at 13:55 +0200, Lukas Wunner wrote:
> I see. In that case, try:
>
> /* handle all the 3-wire mode */
> - if ((spi->mode & SPI_3WIRE) && (tfr->rx_buf))
> + if ((spi->mode & SPI_3WIRE) && (tfr->rx_buf != ctlr->dummy_rx))
> cs |= BCM2835_SPI_CS_REN;
> else
> cs &= ~BCM2835_SPI_CS_REN;
>
This worked fine. Also, I did a quick backport of the state of your
driver's (both spi-bcm2835 and bcm2835-dma) in revpi_staging and it
also worked fine with my device.
So, as far as I understand, the above suggestion (or my patch) is not
intended to be upstreamed, right? It is just a temporary fix that I can
use while your patchset gets upstream.
Thanks for your help!
Nuno Sá
next prev parent reply other threads:[~2019-07-01 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 12:30 [PATCH] spi: spi-bcm2835.c: Fix 3-wire mode Nuno Sá
2019-06-28 15:23 ` Stefan Wahren
2019-06-28 19:00 ` Lukas Wunner
2019-07-01 7:24 ` Sa, Nuno
2019-07-01 11:55 ` Lukas Wunner
2019-07-01 14:21 ` Sa, Nuno [this message]
2019-07-03 10:43 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42a533cbf1e47ab8c8a44c5e865ec15193a2e956.camel@analog.com \
--to=nuno.sa@analog.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@martin.sperl.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).