From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
To: Joerg Roedel <joro@8bytes.org>, Shuah Khan <skhan@linuxfoundation.org>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu: amd: Fix IOMMU perf counter clobbering during init
Date: Tue, 21 Jan 2020 09:10:41 +0700 [thread overview]
Message-ID: <42c0a806-9947-1401-9754-8aa88bd7062f@amd.com> (raw)
In-Reply-To: <20200117100829.GE15760@8bytes.org>
On 1/17/2020 5:08 PM, Joerg Roedel wrote:
> Adding Suravee, who wrote the IOMMU Perf Counter code.
>
> On Tue, Jan 14, 2020 at 08:12:20AM -0700, Shuah Khan wrote:
>> init_iommu_perf_ctr() clobbers the register when it checks write access
>> to IOMMU perf counters and fails to restore when they are writable.
>>
>> Add save and restore to fix it.
>>
>> Signed-off-by: Shuah Khan<skhan@linuxfoundation.org>
>> ---
>> drivers/iommu/amd_iommu_init.c | 22 ++++++++++++++++------
>> 1 file changed, 16 insertions(+), 6 deletions(-)
> Suravee, can you please review this patch?
>
This looks ok. Does this fix certain issues? Or is this just for sanity.
Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Thanks,
Suravee
next prev parent reply other threads:[~2020-01-21 2:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 15:12 [PATCH] iommu: amd: Fix IOMMU perf counter clobbering during init Shuah Khan
2020-01-17 10:08 ` Joerg Roedel
2020-01-21 2:10 ` Suravee Suthikulpanit [this message]
2020-01-21 15:32 ` Shuah Khan
2020-01-23 21:27 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42c0a806-9947-1401-9754-8aa88bd7062f@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).