From: Colin Ian King <colin.king@canonical.com>
To: "Winkler, Tomas" <tomas.winkler@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mei: remove dev_err message on an unsupported ioctl
Date: Tue, 27 Feb 2018 17:31:19 +0000 [thread overview]
Message-ID: <42c81e25-52be-a80e-f304-765c9a71b328@canonical.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B9422A4CC@hasmsx108.ger.corp.intel.com>
On 27/02/18 17:26, Winkler, Tomas wrote:
>>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Currently the driver spams the kernel log on unsupported ioctls which is
>> unnecessary as the ioctl returns -ENOIOCTLCMD to indicate this anyway.
>> I suspect this was originally for debugging purposes but it really is not
>> required so remove it.
>>
>
> This is rather strange as most of the legimit applications are using one IOCTL from kernel 3.0
> Do you have any reference where this call is originated from, frankly this is the first time I got such complain.
I hit this while stressing the kernel with my stress-ng kernel stressing
tool; this was not using the legitimate ioctls (to see if things
explode) and I got a rather full kernel log. So it was being abused
somewhat ;-)
>
> In any case it would be maybe better to change it a warn once call.
Probably so, I can fix that up if that is preferred.
Colin
>
> Thanks
> Tomas
>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/misc/mei/main.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c index
>> 758dc73602d5..7bb013644aeb 100644
>> --- a/drivers/misc/mei/main.c
>> +++ b/drivers/misc/mei/main.c
>> @@ -507,7 +507,6 @@ static long mei_ioctl(struct file *file, unsigned int
>> cmd, unsigned long data)
>> break;
>>
>> default:
>> - dev_err(dev->dev, ": unsupported ioctl %d.\n", cmd);
>> rets = -ENOIOCTLCMD;
>> }
>>
>> --
>> 2.15.1
>
next prev parent reply other threads:[~2018-02-27 17:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 16:21 [PATCH] mei: remove dev_err message on an unsupported ioctl Colin King
2018-02-27 17:26 ` Winkler, Tomas
2018-02-27 17:31 ` Colin Ian King [this message]
2018-02-27 21:47 ` Winkler, Tomas
2018-02-27 18:10 ` Greg Kroah-Hartman
2018-02-27 21:44 ` Winkler, Tomas
2018-02-28 9:49 ` Greg Kroah-Hartman
2018-02-28 9:52 ` Winkler, Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42c81e25-52be-a80e-f304-765c9a71b328@canonical.com \
--to=colin.king@canonical.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).