From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4136CC43461 for ; Wed, 5 May 2021 09:48:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F353B613D6 for ; Wed, 5 May 2021 09:48:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232469AbhEEJt1 (ORCPT ); Wed, 5 May 2021 05:49:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233002AbhEEJtY (ORCPT ); Wed, 5 May 2021 05:49:24 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2536CC061574; Wed, 5 May 2021 02:48:25 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2so1704796lft.4; Wed, 05 May 2021 02:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=T9xggn2FMiHUCK0JlgIAaoS/FDcktmglWb4xoxeN6Tg=; b=RMdoQG/DGvhjj378i2tgVHLSU7jPCo8Q3GAdPuFYp6Els+PiHp77O/IHNmbxSb+hOD IQmq10ICgbhp3gULA5p22NXW7Ify3NZwatHUWvJmWqmPmsMJICeKYccd3dR9Fd6kLiiO 9Le+1+wRrIgHWYku54L1HX8KBNWufzjB9CSpfymTu6w500Vq65JXfzGphiR7zgCT1GMo T2IX3iDpsEDLcQAaCpXuJQF5TtAxym6tyHDnpxcfbaI+zqvUP7vhN+L63tY7QAgFMH2G z5OxOn95+iqqV3mO582NFFtBjB42z1nNiDqBnHdRFcmwpHywoVD1hPOLH48gP9m0/wp3 5P8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=T9xggn2FMiHUCK0JlgIAaoS/FDcktmglWb4xoxeN6Tg=; b=A/0dBZbN6WxJWKP34qS45EVq4fAAiURMAH5wPBMAHYZDOWH3/e5kRfaieo2S9Uwich E1Qa/4P3Tt/6DAy865cMw2oZdgFsUoyZBlYZFGFSJjDIg6cAzqUIit+wTNsBxB0Ebovn 4alShfxF7iMtb7+Fgdj/PLjsRXh3uJodRgz6uoABIm5IdQtMOaB9+MRENJSC8NSBBi0D GYSegakkYW57VKrOfma0TsStNcF/irTvSA5DhJpJfnnVulmYL5ib0i/T4I5I9UDbdnXv Uq0rqLzaAMLwCgQa9ooJwpnpOS0LmOMMxhkUnibC/UBWHnMA0c/N6Ok4Xe/uaetTHvPO RJVA== X-Gm-Message-State: AOAM533uPonWtDQeEKjavvnBIlmVjhd3IXiczp1qn2dY+E09Gjrj/GH0 f7J/HXVvIF+Vx5cy42jxwIkaU3aQxQU= X-Google-Smtp-Source: ABdhPJwNQpAAyMQzifb+wR7LJgqRVho6ApD70rHoAY1Gt66RZsTl0RO2v2lvGHo8oeN2+QIarHBIpQ== X-Received: by 2002:a05:6512:92e:: with SMTP id f14mr19752982lft.347.1620208103478; Wed, 05 May 2021 02:48:23 -0700 (PDT) Received: from [192.168.1.100] ([31.173.83.246]) by smtp.gmail.com with ESMTPSA id z27sm2009990ljn.23.2021.05.05.02.48.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 May 2021 02:48:23 -0700 (PDT) Subject: Re: [PATCH 12/25] media: rcar_fdp1: simplify error check logic at fdp_open() To: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Kieran Bingham , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: From: Sergei Shtylyov Organization: Brain-dead Software Message-ID: <42cf9dff-5c8a-02bd-610f-d88507eb7519@gmail.com> Date: Wed, 5 May 2021 12:48:17 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 05.05.2021 12:42, Mauro Carvalho Chehab wrote: > Avoid some code duplication by moving the common error path > logit at fdp_open(). Logic? > Signed-off-by: Mauro Carvalho Chehab [...] MBR, Sergei