From: Luben Tuikov <luben_tuikov@adaptec.com>
To: Patrick Mansfield <patmans@us.ibm.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, Tejun Heo <htejun@gmail.com>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, Jens Axboe <axboe@suse.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: libata error handling
Date: Fri, 19 Aug 2005 16:43:41 -0400 [thread overview]
Message-ID: <4306447D.7090204@adaptec.com> (raw)
In-Reply-To: <20050819201121.GA2523@us.ibm.com>
On 08/19/05 16:11, Patrick Mansfield wrote:
> On Fri, Aug 19, 2005 at 04:03:15PM -0400, Luben Tuikov wrote:
>>The eh_timed_out + eh_strategy_handler is actually pretty perfect,
>>and _complete_, for any application and purpose in recovering a
>
>
> One other point: Another problems is that we quiesce all shost IO before
> waking up the eh.
Yes, this is true.
> I was changing it to wakeup the eh even while other IO is outstanding, so
> the eh can wakeup and cancel individual commands while other IO is still
> using the HBA.
Hmm, if you want to do this, then SCSI Core needs to know about:
- Domain,
- Domain device and
- LU.
The reason, is that you do not know why a task timed out.
Is it the LU, is it the device, is it the domain?
(Those are concepts talked about in SAM.)
Since currently, SCSI Core has no clue about those concepts,
the current infrastructure, stalling IO to the host on eh,
satisfies.
> So, for EH_NOT_HANDLED, do you add the scmd to a LLDD list in your
> eh_timed_out, then wait for the eh to run?
No, no Patrick, I don't. The SCSI Core does this for me, and then
calls my eh_strategy routine and all the commands are on the list.
> Or maybe your host can_queue is 1 :)
No, it is actually pretty huge for a controller, and have to
more than halve it and give that to SCSI Core.
> I don't see it ... hence my question above.
Hmm, let me know if I'm missing something out.
Luben
next prev parent reply other threads:[~2005-08-19 20:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-29 5:06 [RFC][PATCH] libata ATAPI alignment Jeff Garzik
2005-07-29 13:38 ` Alan Cox
2005-08-02 8:27 ` Jens Axboe
2005-08-02 14:31 ` Jeff Garzik
2005-08-07 5:48 ` Tejun Heo
2005-08-07 5:53 ` [PATCH 1/2] sata: fix sata_sx4 dma_prep to not use sg->length Tejun Heo
2005-08-10 21:24 ` Jeff Garzik
2005-08-07 5:58 ` Rd: [PATCH 2/2] sata: implement ATAPI alignment adjustment Tejun Heo
2005-08-07 6:17 ` [PATCH 3] sata: restore sg on setup failure Tejun Heo
2005-08-19 3:49 ` libata error handling Jeff Garzik
2005-08-19 5:40 ` Tejun Heo
2005-08-19 5:54 ` Jeff Garzik
2005-08-19 19:00 ` Luben Tuikov
2005-08-19 18:46 ` Luben Tuikov
2005-08-19 19:38 ` Patrick Mansfield
2005-08-19 20:03 ` Luben Tuikov
2005-08-19 20:11 ` Patrick Mansfield
2005-08-19 20:43 ` Luben Tuikov [this message]
2005-08-19 21:10 ` Patrick Mansfield
2005-08-19 22:37 ` Luben Tuikov
2005-08-19 20:29 ` Mike Anderson
2005-08-19 21:02 ` Luben Tuikov
2007-01-06 14:26 Kasper Sandberg
[not found] <fa.pdj7pJD9C08bRZatFINV1hz1oyA@ifi.uio.no>
2007-01-06 18:21 ` Robert Hancock
2007-01-06 18:57 ` Kasper Sandberg
2007-01-06 19:01 ` Robert Hancock
2007-01-06 19:08 ` Kasper Sandberg
2007-01-06 19:28 ` Bartlomiej Zolnierkiewicz
2007-01-07 20:07 ` Kasper Sandberg
2007-01-07 20:38 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4306447D.7090204@adaptec.com \
--to=luben_tuikov@adaptec.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=axboe@suse.de \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=patmans@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).