From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Jiri Slaby <jslaby@suse.cz>, gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Helge Deller <deller@gmx.de>, Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
Samuel Iglesias Gonsalvez <siglesias@igalia.com>,
Jens Taprogge <jens.taprogge@taprogge.org>,
Karsten Keil <isdn@linux-pingi.de>,
Ulf Hansson <ulf.hansson@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
Jiri Kosina <jikos@kernel.org>, David Sterba <dsterba@suse.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Oliver Neukum <oneukum@suse.com>, Felipe Balbi <balbi@kernel.org>,
Johan Hovold <johan@kernel.org>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Subject: Re: [PATCH 4/8] tty: stop using alloc_tty_driver
Date: Fri, 23 Jul 2021 09:57:21 +0200 [thread overview]
Message-ID: <4323b79d-45e1-9a80-66dd-87bdbd16cc27@de.ibm.com> (raw)
In-Reply-To: <20210723074317.32690-5-jslaby@suse.cz>
On 23.07.21 09:43, Jiri Slaby wrote:
> alloc_tty_driver was deprecated by tty_alloc_driver in commit
> 7f0bc6a68ed9 (TTY: pass flags to alloc_tty_driver) in 2012.
>
> I never got into eliminating alloc_tty_driver until now. So we still
> have two functions for allocating drivers which might be confusing. So
> get rid of alloc_tty_driver uses to eliminate it for good in the next
> patch.
>
> Note we need to switch return value checking as tty_alloc_driver uses
> ERR_PTR. And flags are now a parameter of tty_alloc_driver.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
[..]
> drivers/s390/char/con3215.c | 7 +++----
> drivers/s390/char/sclp_tty.c | 7 +++----
> drivers/s390/char/sclp_vt220.c | 7 +++----
s390 parts look sane
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
next prev parent reply other threads:[~2021-07-23 7:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 7:43 [PATCH 0/8] Get rid of old tty_driver functions Jiri Slaby
2021-07-23 7:43 ` [PATCH 1/8] xtensa: ISS: don't panic in rs_init Jiri Slaby
2021-07-23 10:18 ` Max Filippov
2021-07-23 7:43 ` [PATCH 2/8] hvsi: don't panic on tty_register_driver failure Jiri Slaby
2021-07-23 7:43 ` [PATCH 3/8] tty: don't store semi-state into tty drivers Jiri Slaby
2021-07-23 10:23 ` Max Filippov
2021-07-23 16:37 ` Helge Deller
2021-07-23 7:43 ` [PATCH 4/8] tty: stop using alloc_tty_driver Jiri Slaby
2021-07-23 7:49 ` Samuel Iglesias Gonsálvez
2021-07-23 7:57 ` Christian Borntraeger [this message]
2021-07-23 10:16 ` David Sterba
2021-07-23 10:30 ` Max Filippov
2021-07-23 7:43 ` [PATCH 5/8] tty: drop alloc_tty_driver Jiri Slaby
2021-07-23 7:43 ` [PATCH 6/8] tty: make tty_set_operations an inline Jiri Slaby
2021-07-23 7:43 ` [PATCH 7/8] tty: drop put_tty_driver Jiri Slaby
2021-07-23 7:49 ` Samuel Iglesias Gonsálvez
2021-07-23 7:55 ` Christian Borntraeger
2021-07-23 10:16 ` David Sterba
2021-07-23 10:32 ` Max Filippov
2021-07-23 12:50 ` Alex Elder
2021-07-23 7:43 ` [PATCH 8/8] tty: pdc_cons, free tty_driver upon failure Jiri Slaby
2021-07-27 10:18 ` [PATCH 0/8] Get rid of old tty_driver functions Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4323b79d-45e1-9a80-66dd-87bdbd16cc27@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=balbi@kernel.org \
--cc=chris@zankel.net \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dsterba@suse.com \
--cc=geert@linux-m68k.org \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=ink@jurassic.park.msu.ru \
--cc=isdn@linux-pingi.de \
--cc=jcmvbkbc@gmail.com \
--cc=jdike@addtoit.com \
--cc=jens.taprogge@taprogge.org \
--cc=jikos@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=johan@kernel.org \
--cc=jslaby@suse.cz \
--cc=kuba@kernel.org \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=mattst88@gmail.com \
--cc=oneukum@suse.com \
--cc=richard@nod.at \
--cc=rth@twiddle.net \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=siglesias@igalia.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).