From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0815C433FE for ; Sat, 19 Nov 2022 21:25:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234488AbiKSVZ4 convert rfc822-to-8bit (ORCPT ); Sat, 19 Nov 2022 16:25:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231445AbiKSVZx (ORCPT ); Sat, 19 Nov 2022 16:25:53 -0500 Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 626D0102 for ; Sat, 19 Nov 2022 13:25:52 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 28C7763E516F; Sat, 19 Nov 2022 22:25:51 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id NjSMm1e3K7LC; Sat, 19 Nov 2022 22:25:50 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id A5E1B63E5157; Sat, 19 Nov 2022 22:25:50 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id UJoQ5eQwxLyi; Sat, 19 Nov 2022 22:25:50 +0100 (CET) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id 8726363E5146; Sat, 19 Nov 2022 22:25:50 +0100 (CET) Date: Sat, 19 Nov 2022 22:25:50 +0100 (CET) From: Richard Weinberger To: "Lihua (lihua, ran)" Cc: Sascha Hauer , linux-mtd , linux-kernel , Wei Yongjun , yusongping@huawei.com Message-ID: <433070166.256175.1668893150374.JavaMail.zimbra@nod.at> In-Reply-To: <23feff35-6f2d-5cd7-57f9-ff2591a3c74e@huawei.com> References: <20221115083335.21211-1-hucool.lihua@huawei.com> <23feff35-6f2d-5cd7-57f9-ff2591a3c74e@huawei.com> Subject: Re: [PATCH] ubifs: Fix build errors as symbol undefined MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF97 (Linux)/8.8.12_GA_3809) Thread-Topic: ubifs: Fix build errors as symbol undefined Thread-Index: xvKUd6iNeIA9uYaj0+JoIBNTDdG+WA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Ursprüngliche Mail ----- > Von: "Lihua (lihua, ran)" >> diff --git a/fs/ubifs/Kconfig b/fs/ubifs/Kconfig >> index 45d3d207fb99..93bda1057fdc 100644 >> --- a/fs/ubifs/Kconfig >> +++ b/fs/ubifs/Kconfig >> @@ -13,6 +13,7 @@ config UBIFS_FS >> select CRYPTO_HASH_INFO >> select UBIFS_FS_XATTR if FS_ENCRYPTION >> select FS_ENCRYPTION_ALGS if FS_ENCRYPTION >> + select UBIFS_FS_AUTHENTICATION I fear this is not a proper fix. This changes does not longer allow building UBIFS without the authentication feature. With what configuration do you see this error? I just tried with: CONFIG_UBIFS_FS=m CONFIG_UBIFS_FS_ADVANCED_COMPR=y CONFIG_UBIFS_FS_LZO=y CONFIG_UBIFS_FS_ZLIB=y CONFIG_UBIFS_FS_ZSTD=y CONFIG_UBIFS_ATIME_SUPPORT=y CONFIG_UBIFS_FS_XATTR=y CONFIG_UBIFS_FS_SECURITY=y # CONFIG_UBIFS_FS_AUTHENTICATION is not set But don't get the error and, as expected, fs/ubifs/ubifs.o has no reference to ubifs_bad_hash. Thanks, //richard