From: Patrice CHOTARD <patrice.chotard@st.com>
To: Sriram Dash <sriram.dash@samsung.com>,
'Jose Abreu' <Jose.Abreu@synopsys.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: 'Joao Pinto' <Joao.Pinto@synopsys.com>,
"'kernelci . org bot'" <bot@kernelci.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"'David S. Miller'" <davem@davemloft.net>,
'Florian Fainelli' <f.fainelli@gmail.com>,
'Maxime Coquelin' <mcoquelin.stm32@gmail.com>,
Peppe CAVALLARO <peppe.cavallaro@st.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
'Heiko Stuebner' <heiko@sntech.de>
Subject: Re: [Linux-stm32] [PATCH net] net: stmmac: Fixed link does not need MDIO Bus
Date: Tue, 7 Jan 2020 13:30:14 +0000 [thread overview]
Message-ID: <4330eb5a-1dfa-783c-69c9-35692db65341@st.com> (raw)
In-Reply-To: <014201d5c559$3e6204b0$bb260e10$@samsung.com>
Hi All
On 1/7/20 1:51 PM, Sriram Dash wrote:
>> From: Jose Abreu <Jose.Abreu@synopsys.com>
>> Subject: [PATCH net] net: stmmac: Fixed link does not need MDIO Bus
>>
>> When using fixed link we don't need the MDIO bus support.
>>
>> Reported-by: Heiko Stuebner <heiko@sntech.de>
>> Reported-by: kernelci.org bot <bot@kernelci.org>
>> Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms
>> without PHY")
>> Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com>
> Acked-by: Sriram Dash <Sriram.dash@samsung.com>
Tested on STiH410-B2260 board
Tested-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
>> ---
>> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
>> Cc: Alexandre Torgue <alexandre.torgue@st.com>
>> Cc: Jose Abreu <joabreu@synopsys.com>
>> Cc: "David S. Miller" <davem@davemloft.net>
>> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
>> Cc: netdev@vger.kernel.org
>> Cc: linux-stm32@st-md-mailman.stormreply.com
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: linux-kernel@vger.kernel.org
>> Cc: Heiko Stuebner <heiko@sntech.de>
>> Cc: kernelci.org bot <bot@kernelci.org>
>> Cc: Florian Fainelli <f.fainelli@gmail.com>
>> Cc: Sriram Dash <sriram.dash@samsung.com>
>> ---
>> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> index cc8d7e7bf9ac..4775f49d7f3b 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> @@ -320,7 +320,7 @@ static int stmmac_mtl_setup(struct platform_device
>> *pdev, static int stmmac_dt_phy(struct plat_stmmacenet_data *plat,
>> struct device_node *np, struct device *dev) {
>> - bool mdio = false;
>> + bool mdio = !of_phy_is_fixed_link(np);
>> static const struct of_device_id need_mdio_ids[] = {
>> { .compatible = "snps,dwc-qos-ethernet-4.10" },
>> {},
>> --
>> 2.7.4
>
> _______________________________________________
> Linux-stm32 mailing list
> Linux-stm32@st-md-mailman.stormreply.com
> https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32
next prev parent reply other threads:[~2020-01-07 13:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200107123550epcas5p2d1914646e71e0ff0095b4a14eb5e1551@epcas5p2.samsung.com>
2020-01-07 12:35 ` [PATCH net] net: stmmac: Fixed link does not need MDIO Bus Jose Abreu
2020-01-07 12:51 ` Sriram Dash
2020-01-07 13:30 ` Patrice CHOTARD [this message]
2020-01-07 14:10 ` Heiko Stübner
2020-01-07 14:23 ` Neil Armstrong
2020-01-07 19:05 ` Florian Fainelli
2020-01-07 21:42 ` David Miller
2020-01-07 21:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4330eb5a-1dfa-783c-69c9-35692db65341@st.com \
--to=patrice.chotard@st.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=bot@kernelci.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=sriram.dash@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).