From: Peter Staubach <staubach@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "Lever, Charles" <Charles.Lever@netapp.com>,
SteveD@redhat.com, NFS@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Trond Myklebust <trond.myklebust@fys.uio.no>
Subject: Re: [NFS] Re: [PATCH] repair nfsd/sunrpc in 2.6.14-rc2-mm1 (and other -mm versions)
Date: Thu, 22 Sep 2005 15:46:31 -0400 [thread overview]
Message-ID: <43330A17.4050305@redhat.com> (raw)
In-Reply-To: <20050922123150.7a147d1e.akpm@osdl.org>
Andrew Morton wrote:
>"Lever, Charles" <Charles.Lever@netapp.com> wrote:
>
>
>>>-----Original Message-----
>>>
>>>
>> > From: Steve Dickson [mailto:SteveD@redhat.com]
>> > Sent: Thursday, September 22, 2005 10:02 AM
>> > To: linux-kernel
>> > Cc: NFS@lists.sourceforge.net
>> > Subject: [NFS] Re: [PATCH] repair nfsd/sunrpc in
>> > 2.6.14-rc2-mm1 (and other -mm versions)
>> >
>> > Max Kellermann wrote:
>> > > Your -mm patches make the sunrpc client connect to the
>> > portmapper with
>> > > a non-privileged source port. This is due to a change in
>> > > net/sunrpc/pmap_clnt.c, which manually resets the xprt->resvport
>> > > field. My tiny patch removes this line. I have no idea
>> > why the line
>> > > was added in the first place, does somebody know better?
>> > Yes this is a bug, since most Linux portmapper will not
>> > allow ports to be set or unset using non-privilege ports.
>> > But non-privilege ports can be used to get ports information.
>> > So I would suggest the following patch that stops the
>> > use of privileges ports on only get port requests.
>>
>> this was my patch (idea was steve's). i've already sent a fix to
>> andrew. andrew please let me know if you haven't received it.
>>
>>
>
>Ah, good. Please resend?
>
Actually, Chuck's patch and Steve's aren't quite the same. Both patches
fix the problem that the portmap daemon requires a request to set something
to come from a reserved port. In addition to this, Steve's patch reduces
the number of reserved ports that the kernel requires. This is the problem
that resulted in pmap_create() being incorrectly modified in the first
place.
Steve's patch correctly puts the support in rpc_getport() where it belongs.
Thanx...
ps
next prev parent reply other threads:[~2005-09-22 19:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-22 14:11 [NFS] Re: [PATCH] repair nfsd/sunrpc in 2.6.14-rc2-mm1 (and other -mm versions) Lever, Charles
2005-09-22 19:31 ` Andrew Morton
2005-09-22 19:46 ` Peter Staubach [this message]
2005-09-22 19:53 Lever, Charles
2005-09-22 20:08 ` Peter Staubach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43330A17.4050305@redhat.com \
--to=staubach@redhat.com \
--cc=Charles.Lever@netapp.com \
--cc=NFS@lists.sourceforge.net \
--cc=SteveD@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).