From: Jens Axboe <axboe@kernel.dk>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] eventfd: convert to f_op->read_iter()
Date: Sun, 3 May 2020 08:42:41 -0600 [thread overview]
Message-ID: <435c171c-37aa-8f7d-c506-d1e8f07f4bc7@kernel.dk> (raw)
In-Reply-To: <20200503134622.GS23230@ZenIV.linux.org.uk>
On 5/3/20 7:46 AM, Al Viro wrote:
> On Fri, May 01, 2020 at 05:54:09PM -0600, Jens Axboe wrote:
>> On 5/1/20 5:12 PM, Al Viro wrote:
>>> On Fri, May 01, 2020 at 01:11:09PM -0600, Jens Axboe wrote:
>>>> + flags &= EFD_SHARED_FCNTL_FLAGS;
>>>> + flags |= O_RDWR;
>>>> + fd = get_unused_fd_flags(flags);
>>>> if (fd < 0)
>>>> - eventfd_free_ctx(ctx);
>>>> + goto err;
>>>> +
>>>> + file = anon_inode_getfile("[eventfd]", &eventfd_fops, ctx, flags);
>>>> + if (IS_ERR(file)) {
>>>> + put_unused_fd(fd);
>>>> + fd = PTR_ERR(file);
>>>> + goto err;
>>>> + }
>>>>
>>>> + file->f_mode |= FMODE_NOWAIT;
>>>> + fd_install(fd, file);
>>>> + return fd;
>>>> +err:
>>>> + eventfd_free_ctx(ctx);
>>>> return fd;
>>>> }
>>>
>>> Looks sane... I can take it via vfs.git, or leave it for you if you
>>> have other stuff in the same area...
>>
>> Would be great if you can queue it up in vfs.git, thanks! Don't have
>> anything else that'd conflict with this.
>
> Applied; BTW, what happens if
> ctx->id = ida_simple_get(&eventfd_ida, 0, 0, GFP_KERNEL);
> fails? Quitely succeed with BS value (-ENOSPC/-ENOMEM) shown by
> eventfd_show_fdinfo()?
Huh yeah that's odd, not sure how I missed that when touching code
near it. Want a followup patch to fix that issue?
--
Jens Axboe
next prev parent reply other threads:[~2020-05-03 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 19:11 [PATCH v4] eventfd: convert to f_op->read_iter() Jens Axboe
2020-05-01 23:12 ` Al Viro
2020-05-01 23:54 ` Jens Axboe
2020-05-03 13:46 ` Al Viro
2020-05-03 14:42 ` Jens Axboe [this message]
2020-05-03 16:50 ` Jens Axboe
2020-05-04 12:39 ` Christoph Hellwig
2020-05-08 8:58 ` [eventfd] a4ef93e263: will-it-scale.per_process_ops -2.2% regression kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=435c171c-37aa-8f7d-c506-d1e8f07f4bc7@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).