From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756258AbcIFNoA (ORCPT ); Tue, 6 Sep 2016 09:44:00 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:60661 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755445AbcIFNn6 (ORCPT ); Tue, 6 Sep 2016 09:43:58 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: rmk+kernel@armlinux.org.uk, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] drm/armada: mark symbols static where possible Date: Tue, 06 Sep 2016 15:44:13 +0200 Message-ID: <4374246.7oBh2V74yj@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1473147475-24639-1-git-send-email-baoyou.xie@linaro.org> References: <1473147475-24639-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:JBvafbLV2iaDEVC+ZucWZtEmZoBXfYLH7gVuDLODnf5pOR2VOFv SZxW1N11yABZt19q/DSyV/7CahppjqnmXJa4zZlI4mt/PJ7e47pE5RqHs1F80tUGm6KAZMO QHPdOtUQFIWDVRA0QRTtStsyKGvrGTprTpGwcRvf1TN9IpHTEl992z8H8vvcCwbMgdxqusg aXa85j7AeyJvn4JuCJhGA== X-UI-Out-Filterresults: notjunk:1;V01:K0:fgEK0XDMyjY=:376ntHvVZHDFhXwwiJ/5Cv yOxghCLB5f35CpCxTuukllqObsIkLrlgpOqn4shVINh+jQL2+8xi4UH8m8fuvKf7PzjE6SCPQ Vgu4+BV70B0oXR+dXVAkk0OUOeYGQbgYBNeV5J032b6wp47LOpZC5mhqJRqFo4nc9ReOd6/GK gmw6Zs7kTkvPMm6KQQavkqMPkdz4yuIPcwm2YtgIz7+uoq2EwlH65smyZ867rs47EfNTmBknV CXdERYzxrghg009c31LV2vTK/+IE4ugK9QzYGTfu8ZPhle/9h9r1asqkzTTManHinPDuUPGUV +J2otLd6ORclQSeF3lafv9RLhgQ+MVIfjqX94i/aV63CzXq1tz3KJ+sMVn4j21rYcfy9nULV8 gu/7DY+dQALUQ4plmm9dxQid6ISvRPUbcjz+Kv7eUR2l6q3qv8dYzL+KZPoSPq8HEopRGlK7T wUH+FFTi7Kix6dcR/jU4ytmD4D8LbNEeJGMzdcnegWjEaEGqyoKQf7tez0tbrwtHjfTmaSpQv UZfdzG0xYz6Q4MGjtyyky8yr14V1/7ZLUiuYQQIlYUXY9Nx1hj3P3tdkhLpI0+YNEW2X23cF6 X9n8oGkNaXW+cS91TkdpZpP7CR8g/diQ5XOtBsd8SPCTiXUt3OYk/M4TjsW/M8+fq1bZbcxls IX2i/sfQ2RVMjS8mka6jJqaJrku8rgmoDjoK2LzF2bdnFhO6mkOra68hhfhIa1ewka5wo+XKI NlrRojbyRRzze2BV Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, September 6, 2016 3:37:55 PM CEST Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/armada/armada_gem.c:215:27: warning: no previous prototype for 'armada_gem_alloc_object' [-Wmissing-prototypes] > drivers/gpu/drm/armada/armada_gem.c:423:1: warning: no previous prototype for 'armada_gem_prime_map_dma_buf' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > Acked-by: Arnd Bergmann