linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: jingbao qiu <qiujingbao.dlmu@gmail.com>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
	krzysztof.kozlowski+dt@linaro.org, chao.wei@sophgo.com,
	unicorn_wang@outlook.com, conor+dt@kernel.org,
	robh+dt@kernel.org, conor@kernel.org, paul.walmsley@sifive.com,
	palmer@dabbelt.com, aou@eecs.berkeley.edu,
	linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] rtc: add rtc controller support for Sophgo CV1800B SoC
Date: Tue, 28 Nov 2023 14:59:37 +0100	[thread overview]
Message-ID: <438768a3-c50c-46f1-8a4e-2233c7545453@linaro.org> (raw)
In-Reply-To: <CAJRtX8TU9Z3OXL1zw9+mGNhxugp_C2jo40k-s9V2byNCQeBoLQ@mail.gmail.com>

On 28/11/2023 14:22, jingbao qiu wrote:
>>> +     if (ret)
>>> +             goto err;
>>> +
>>> +     rtc->clk = devm_clk_get(&pdev->dev, NULL);
>>> +     if (IS_ERR(rtc->clk)) {
>>> +             dev_err(&pdev->dev, "no clock");
>>
>> This code is not ready for upstream. There are multiple things wrong here.
>>
>> First, syntax is return dev_err_probe.
>>
>> Second, you do not have clocks and you do not allow them! Just open your
>> binding.
> 
> I'm not fully understanding here, can you elaborate more?

That the syntax is dev_err_probe() or that you do not have clocks?


> as there is clocks info like this in the dt-bindings:
>  clocks = <&osc>;

Really?

Point me to the line in your patch:

+properties:
+  compatible:
+    enum:
+      - sophgo,cv1800b-rtc
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts

Where are the clocks?


Best regards,
Krzysztof


  reply	other threads:[~2023-11-28 13:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-21  9:46 [PATCH 0/3] riscv: sophgo: add rtc support for CV1800B Jingbao Qiu
2023-11-21  9:46 ` [PATCH 1/3] dt-bindings: rtc: add binding for Sophgo CV1800B rtc controller Jingbao Qiu
2023-11-21  9:57   ` Krzysztof Kozlowski
2023-11-28 13:20     ` jingbao qiu
2023-11-21 10:37   ` Rob Herring
2023-11-21  9:46 ` [PATCH 2/3] rtc: add rtc controller support for Sophgo CV1800B SoC Jingbao Qiu
2023-11-21 10:01   ` Krzysztof Kozlowski
2023-11-28 13:22     ` jingbao qiu
2023-11-28 13:59       ` Krzysztof Kozlowski [this message]
2023-11-28 14:34         ` jingbao qiu
2023-11-28 23:01       ` Alexandre Belloni
2023-11-21 17:58   ` kernel test robot
2023-11-21 22:52   ` kernel test robot
2023-11-21  9:46 ` [PATCH 3/3] riscv: dts: sophgo: add rtc dt node for CV1800B Jingbao Qiu
2023-11-21 10:00   ` Krzysztof Kozlowski
2023-11-28 13:23     ` jingbao qiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=438768a3-c50c-46f1-8a4e-2233c7545453@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=chao.wei@sophgo.com \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=qiujingbao.dlmu@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=unicorn_wang@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).