From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA3E5C433EF for ; Tue, 14 Sep 2021 22:48:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AED9D61175 for ; Tue, 14 Sep 2021 22:48:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235741AbhINWtT (ORCPT ); Tue, 14 Sep 2021 18:49:19 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:47552 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235083AbhINWtS (ORCPT ); Tue, 14 Sep 2021 18:49:18 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7C0F322146; Tue, 14 Sep 2021 22:47:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1631659679; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0vqgHxptFilI+52z7LDkXnCdgIqfeyzwesZHjTddRvQ=; b=vlKcsoRevVDE4QM2CQlxH5yAblVY+W2Om5b8nNLEhiROlotFE13KJy5hvpOaJAdnqALZ66 FRaIVBktsb7j2IHYVg56S2J/MNS7BXHHlXyn0z/kBDE0KDi2wuG0ISJQNEFsd/owfpiRlQ bItHfwgm7VxNv2Hsfppb14+ZP/6zo8I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1631659679; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0vqgHxptFilI+52z7LDkXnCdgIqfeyzwesZHjTddRvQ=; b=0oi9K/0RQ71UYGVu2ipyGx9jQ2myDnsW0oyjjUGV4oVjW8PqLUrUbDVf4GZbkyWXjnIQml H4W6LOllQTLQVzCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5A3BD13B4E; Tue, 14 Sep 2021 22:47:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9YhkFZ8mQWHsVwAAMHmgww (envelope-from ); Tue, 14 Sep 2021 22:47:59 +0000 Message-ID: <4392e867-0cce-d04a-e3d1-cba152daaa1f@suse.cz> Date: Wed, 15 Sep 2021 00:47:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [GIT PULL] tracing: Fixes to bootconfig memory management Content-Language: en-US To: Steven Rostedt , Linus Torvalds Cc: Mike Rapoport , Andrew Morton , LKML , Ingo Molnar , Masami Hiramatsu , Linux-MM References: <20210914105620.677b90e5@oasis.local.home> <20210914145953.189f15dc@oasis.local.home> <20210914170553.7c1e1faa@oasis.local.home> From: Vlastimil Babka In-Reply-To: <20210914170553.7c1e1faa@oasis.local.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/14/21 23:05, Steven Rostedt wrote: > On Tue, 14 Sep 2021 13:48:15 -0700 > Linus Torvalds wrote: > >> On Tue, Sep 14, 2021 at 12:38 PM Linus Torvalds >> wrote: >> > >> > So I'll do a minimal conversion that adds "memblock_free_ptr()" and >> > hope that people start using that. And then we can later try to move >> > "memblock_free()" to a name that isn't so misleading. >> >> Commit 77e02cf57b6c ("memblock: introduce saner 'memblock_free_ptr()' >> interface") should hopefully fix that panic that Vlastimil saw, and >> the kernel test robot report as well. >> >> And it should make it easy to cleanly fix that 'copy' leak too. >> > > Vlastimil, > > Can you confirm that Linus's changes addresses your issue? Well, looks like I can't. Commit 77e02cf57b6cf does boot fine for me, multiple times. But so now does the parent commit 6a4746ba06191. Looks like the magic is gone. I'm now surprised how deterministic it was during the bisect (most bad cases manifested on first boot, only few at second). > Masami, > > Care to rebase on top of Linus's change? > > Thanks! > > -- Steve >