From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: Kristen Accardi <kristen.c.accardi@intel.com>
Cc: pcihpd-discuss@lists.sourceforge.net,
linux-kernel@vger.kernel.org, rajesh.shah@intel.com,
greg@kroah.com
Subject: Re: [Pcihpd-discuss] [PATCH] acpiphp: only size new bus
Date: Wed, 14 Dec 2005 13:21:23 +0900 [thread overview]
Message-ID: <439F9DC3.5020303@jp.fujitsu.com> (raw)
In-Reply-To: <1134524986.6886.77.camel@whizzy>
Hi Kristen,
> + if (pass)
> + if (dev->subordinate)
> + pci_bus_size_bridges(dev->subordinate);
How about doing as follows. This also satisfies 80 columns rule.
if (pass && dev->subordinate)
pci_bus_size_bridges(dev->subordinate);
Thanks,
Kenji Kaneshige
Kristen Accardi wrote:
> Only size the bus that has been added.
>
> Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
>
> drivers/pci/hotplug/acpiphp_glue.c | 4 +++-
> drivers/pci/hotplug/acpiphp_glue.c | 7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
> --- linux-2.6.15-rc5.orig/drivers/pci/hotplug/acpiphp_glue.c
> +++ linux-2.6.15-rc5/drivers/pci/hotplug/acpiphp_glue.c
> @@ -794,12 +794,15 @@ static int enable_device(struct acpiphp_
> if (PCI_SLOT(dev->devfn) != slot->device)
> continue;
> if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE ||
> - dev->hdr_type == PCI_HEADER_TYPE_CARDBUS)
> + dev->hdr_type == PCI_HEADER_TYPE_CARDBUS) {
> max = pci_scan_bridge(bus, dev, max, pass);
> + if (pass)
> + if (dev->subordinate)
> + pci_bus_size_bridges(dev->subordinate);
> + }
> }
> }
>
> - pci_bus_size_bridges(bus);
> pci_bus_assign_resources(bus);
> acpiphp_sanitize_bus(bus);
> pci_enable_bridges(bus);
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
> for problems? Stop! Download the new AJAX search engine that makes
> searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________
> Pcihpd-discuss mailing list
> Pcihpd-discuss@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/pcihpd-discuss
>
next prev parent reply other threads:[~2005-12-14 4:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-14 1:49 [PATCH] acpiphp: only size new bus Kristen Accardi
2005-12-14 4:21 ` Kenji Kaneshige [this message]
2005-12-14 17:37 ` [Pcihpd-discuss] " Kristen Accardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=439F9DC3.5020303@jp.fujitsu.com \
--to=kaneshige.kenji@jp.fujitsu.com \
--cc=greg@kroah.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pcihpd-discuss@lists.sourceforge.net \
--cc=rajesh.shah@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).