From: Anderson Briglia <anderson.briglia@indt.org.br>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-kernel@vger.kernel.org,
"Linux-omap-open-source@linux.omap.com"
<linux-omap-open-source@linux.omap.com>,
linux@arm.linux.org.uk, ext David Brownell <david-b@pacbell.net>,
drzeus-list@drzeus.cx,
"Aguiar Carlos (EXT-INdT/Manaus)" <carlos.aguiar@indt.org.br>,
"Lizardo Anderson (EXT-INdT/Manaus)"
<anderson.lizardo@indt.org.br>
Subject: Re: [patch 1/5] Add MMC password protection (lock/unlock) support V3
Date: Wed, 11 Jan 2006 15:27:55 -0400 [thread overview]
Message-ID: <43C55C3B.3090207@indt.org.br> (raw)
In-Reply-To: <20060111181459.GF4422@atomide.com>
Tony Lindgren wrote:
> * Russell King <rmk+lkml@arm.linux.org.uk> [060111 06:44]:
>
>>On Wed, Jan 11, 2006 at 09:16:28AM -0400, Anderson Briglia wrote:
>>
>>>Russell King wrote:
>>>
>>>
>>>>On Mon, Jan 09, 2006 at 06:15:00PM -0400, Anderson Briglia wrote:
>>>>
>>>>
>>>>
>>>>>When a card is locked, only commands from the "basic" and "lock card" classes
>>>>>are accepted. To be able to use the other commands, the card must be unlocked
>>>>>first.
>>>>>
>>>>>
>>>>
>>>>I don't think this works as you intend.
>>>>
>>>>When a card is initially inserted, we discover the cards via mmc_setup()
>>>>and mmc_discover_cards(). This means that we'll never set the locked
>>>>status for newly inserted cards.
>>>>
>>>>
>>>
>>>mmc_setup() calls mmc_check_cards(). Our patch adds the necessary code
>>>to mmc_check_cards() to set the locked state when the card is locked.
>>
>>Not in Linus' kernel, it doesn't.
>>
>>If you're working off the OMAP tree, bear in mind that I've found in
>>the past that they have a large number of wrong or inappropriate
>>changes to the MMC layer in there. They don't regularly merge either,
>>and they certainly don't forward any bug fixes for review in a timely
>>manner.
>
>
> I agree the omap MMC driver should be cleaned-up and finally merged.
>
> Anderson, since you are already patching it, do you want to take care of
> cleaning it up a bit and posting it here?
OK Tony. I'll do it and post here asap.
Regards,
Anderson Briglia
INdT - Manaus
next prev parent reply other threads:[~2006-01-11 19:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-09 22:15 [patch 1/5] Add MMC password protection (lock/unlock) support V3 Anderson Briglia
2006-01-09 22:29 ` Russell King
2006-01-11 13:16 ` Anderson Briglia
2006-01-11 14:44 ` Russell King
2006-01-11 18:14 ` Tony Lindgren
2006-01-11 19:27 ` Anderson Briglia [this message]
2006-01-11 19:49 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43C55C3B.3090207@indt.org.br \
--to=anderson.briglia@indt.org.br \
--cc=anderson.lizardo@indt.org.br \
--cc=carlos.aguiar@indt.org.br \
--cc=david-b@pacbell.net \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap-open-source@linux.omap.com \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).