From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Diego Calleja <diegocg@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Oops with current linus' git tree
Date: Tue, 17 Jan 2006 15:24:09 +1100 [thread overview]
Message-ID: <43CC7169.6030301@yahoo.com.au> (raw)
In-Reply-To: <43CC7094.9040404@yahoo.com.au>
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
Nick Piggin wrote:
> Diego Calleja wrote:
>
>> I'm having two noticeable problems with the current linus' tree
>>
>> 1) Oops while watching a DVD with kaffeine (kde based video player),
>> oops pasted below.
>>
>
> From your oops it looks as though the radix_tree_lookup in find_get_page
> has returned 0x40. It could be a flipped bit - is your memory OK?
>
> Can you apply the attached patch and try to reproduce the oops?
>
Really attached now.
--
SUSE Labs, Novell Inc.
[-- Attachment #2: radix-tree-debug.patch --]
[-- Type: text/plain, Size: 766 bytes --]
Index: linux-2.6/lib/radix-tree.c
===================================================================
--- linux-2.6.orig/lib/radix-tree.c 2006-01-03 19:05:57.000000000 +1100
+++ linux-2.6/lib/radix-tree.c 2006-01-17 15:17:36.000000000 +1100
@@ -233,6 +233,8 @@ int radix_tree_insert(struct radix_tree_
int offset;
int error;
+ BUG_ON((unsigned long)item < PAGE_OFFSET);
+
/* Make sure the tree is high enough. */
if ((!index && !root->rnode) ||
index > radix_tree_maxindex(root->height)) {
@@ -334,6 +336,8 @@ void *radix_tree_lookup(struct radix_tre
void **slot;
slot = __lookup_slot(root, index);
+ if (slot && *slot)
+ BUG_ON((unsigned long)(*slot) < PAGE_OFFSET);
return slot != NULL ? *slot : NULL;
}
EXPORT_SYMBOL(radix_tree_lookup);
next prev parent reply other threads:[~2006-01-17 4:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-16 18:15 Oops with current linus' git tree Diego Calleja
2006-01-17 4:20 ` Nick Piggin
2006-01-17 4:24 ` Nick Piggin [this message]
2006-01-17 13:17 ` Diego Calleja
2006-01-18 0:20 ` Diego Calleja
2006-01-18 3:23 ` Nick Piggin
2006-01-19 19:31 ` Diego Calleja
2006-01-18 3:25 ` Nick Piggin
2006-01-18 14:02 ` Diego Calleja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43CC7169.6030301@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=diegocg@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).