From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S964944AbWAREqk@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964944AbWAREqk (ORCPT <rfc822;willy@w.ods.org>);
	Tue, 17 Jan 2006 23:46:40 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964937AbWAREqk
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 17 Jan 2006 23:46:40 -0500
Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:16317 "EHLO
	fgwmail6.fujitsu.co.jp") by vger.kernel.org with ESMTP
	id S964938AbWAREqj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 17 Jan 2006 23:46:39 -0500
Message-ID: <43CDC75B.8070408@jp.fujitsu.com>
Date: Wed, 18 Jan 2006 13:43:07 +0900
From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923)
X-Accept-Language: ja, en-us, en
MIME-Version: 1.0
To: Kristen Accardi <kristen.c.accardi@intel.com>
CC: linux-kernel@vger.kernel.org, greg@kroah.com,
       pcihpd-discuss@lists.sourceforge.net, len.brown@intel.com,
       linux-acpi@vger.kernel.org, pavel@ucw.cz
Subject: Re: [Pcihpd-discuss] [patch 2/4]  acpiphp: handle dock bridges
References: <20060116200218.275371000@whizzy> <1137545819.19858.47.camel@whizzy>
In-Reply-To: <1137545819.19858.47.camel@whizzy>
Content-Type: text/plain; charset=ISO-2022-JP
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

Kristen Accardi wrote:
> +static acpi_status handle_dock(struct acpiphp_func *func, int dock)
> +{
> +	acpi_status status;
> +	struct acpi_object_list arg_list;
> +	union acpi_object arg;
> +	struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER, NULL};
> +
> +	dbg("%s: enter\n", __FUNCTION__);
> +
> +	/* _DCK method has one argument */
> +	arg_list.count = 1;
> +	arg_list.pointer = &arg;
> +	arg.type = ACPI_TYPE_INTEGER;
> +	arg.integer.value = dock;
> +	status = acpi_evaluate_object(func->handle, "_DCK",
> +					&arg_list, &buffer);
> +	if (ACPI_FAILURE(status))
> +		err("%s: failed to dock!!\n", MY_NAME);
> +
> +	return status;
> +}

I think you need to add acpi_os_free() for freeing buffer.pointer.

Thanks,
Kenji Kaneshige