linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Reuben Farrelly <reuben-lkml@reub.net>, Andrew Morton <akpm@osdl.org>
Cc: stern@rowland.harvard.edu, linux-kernel@vger.kernel.org,
	greg@kroah.com,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	neilb@cse.unsw.edu.au, linux-acpi@vger.kernel.org
Subject: [PATCH] Re: [linux-usb-devel] Re: 2.6.15-mm3 [USB lost interrupt bug]
Date: Sat, 21 Jan 2006 03:32:18 -0500	[thread overview]
Message-ID: <43D1F192.3060406@pobox.com> (raw)
In-Reply-To: <43D1E9A4.8090504@reub.net>

[-- Attachment #1: Type: text/plain, Size: 85 bytes --]


On the libata side of things, does this patch produce any useful results?

	Jeff




[-- Attachment #2: patch.pci-region-check --]
[-- Type: text/plain, Size: 1544 bytes --]

diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index 46c4cdb..4691f8d 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -4794,7 +4794,14 @@ ata_pci_init_native_mode(struct pci_dev 
 			pci_resource_start(pdev, 1) | ATA_PCI_CTL_OFS;
 		probe_ent->port[p].bmdma_addr = pci_resource_start(pdev, 4);
 		ata_std_ports(&probe_ent->port[p]);
-		p++;
+
+		if (pci_resource_start(pdev, 0) &&
+		    pci_resource_len(pdev, 0) &&
+		    pci_resource_start(pdev, 1) &&
+		    pci_resource_len(pdev, 1) &&
+		    pci_resource_start(pdev, 4) &&
+		    pci_resource_len(pdev, 4))
+			p++;
 	}
 
 	if (ports & ATA_PORT_SECONDARY) {
@@ -4804,10 +4811,23 @@ ata_pci_init_native_mode(struct pci_dev 
 			pci_resource_start(pdev, 3) | ATA_PCI_CTL_OFS;
 		probe_ent->port[p].bmdma_addr = pci_resource_start(pdev, 4) + 8;
 		ata_std_ports(&probe_ent->port[p]);
-		p++;
+
+		if (pci_resource_start(pdev, 2) &&
+		    pci_resource_len(pdev, 2) &&
+		    pci_resource_start(pdev, 3) &&
+		    pci_resource_len(pdev, 3) &&
+		    pci_resource_start(pdev, 4) &&
+		    pci_resource_len(pdev, 4) > 8)
+			p++;
 	}
 
 	probe_ent->n_ports = p;
+
+	if (p == 0) {
+		kfree(probe_ent);
+		probe_ent = NULL;
+	}
+
 	return probe_ent;
 }
 
@@ -4815,6 +4835,10 @@ static struct ata_probe_ent *ata_pci_ini
 {
 	struct ata_probe_ent *probe_ent;
 
+	if (!pci_resource_start(pdev, 4) ||
+	    !pci_resource_len(pdev, 4))
+		return NULL;
+
 	probe_ent = ata_probe_ent_alloc(pci_dev_to_dev(pdev), port);
 	if (!probe_ent)
 		return NULL;

  reply	other threads:[~2006-01-21  8:32 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-11 12:21 2.6.15-mm3 Andrew Morton
2006-01-11 13:43 ` 2.6.15-mm3 Pekka Enberg
2006-01-11 14:27 ` 2.6.15-mm3 Ashutosh Naik
2006-01-11 16:21 ` 2.6.15-mm3 Dominik Karall
2006-01-11 22:22   ` 2.6.15-mm3, current -git: drivers/media/video/ compile errors Adrian Bunk
2006-01-11 22:48     ` Mauro Carvalho Chehab
2006-01-11 16:57 ` [PATCH -mm] mm/rmap.c: don't forget to include module.h Alexey Dobriyan
2006-01-11 21:42   ` Adrian Bunk
2006-01-11 21:50     ` Christoph Lameter
2006-01-11 18:25 ` 2.6.15-mm3 Roman Zippel
2006-01-11 18:45   ` 2.6.15-mm3 Andrew Morton
2006-01-11 22:26     ` 2.6.15-mm3 Roman Zippel
2006-01-11 18:34 ` 2.6.15-mm3 Brice Goglin
2006-01-11 18:40   ` 2.6.15-mm3 Dominik Brodowski
2006-01-11 19:07     ` 2.6.15-mm3 Brice Goglin
2006-01-11 19:55       ` 2.6.15-mm3 Dominik Brodowski
2006-01-11 20:28         ` 2.6.15-mm3 Brice Goglin
2006-01-11 21:21           ` 2.6.15-mm3 Dominik Brodowski
2006-01-11 22:47             ` 2.6.15-mm3 Brice Goglin
2006-01-11 23:00               ` 2.6.15-mm3 Dominik Brodowski
2006-01-11 23:23                 ` 2.6.15-mm3 Brice Goglin
2006-01-11 18:49   ` 2.6.15-mm3 Andrew Morton
2006-01-11 21:39 ` 2.6.15-mm3 Grant Coady
2006-01-11 23:41 ` 2.6.15-mm3: arch/ia64/sn/kernel/sn2/sn_proc_fs.c compile error Adrian Bunk
2006-01-12  0:01   ` Andrew Morton
2006-01-12  0:17     ` Adrian Bunk
2006-01-12  0:23       ` Andrew Morton
2006-01-12  0:54         ` Adrian Bunk
2006-01-12  1:02 ` [-mm patch] fix arch/ia64/sn/kernel/tiocx.c compilation Adrian Bunk
2006-01-12 16:43   ` Greg KH
2006-01-12  4:04 ` 2.6.15-mm3 Reuben Farrelly
2006-01-12  4:33   ` 2.6.15-mm3 Andrew Morton
2006-01-12  4:38     ` 2.6.15-mm3 Reuben Farrelly
2006-01-12  8:54     ` 2.6.15-mm3 [USB lost interrupt bug] Reuben Farrelly
2006-01-12 15:53       ` [linux-usb-devel] " Alan Stern
2006-01-15 22:50         ` Reuben Farrelly
2006-01-16  3:22           ` Alan Stern
2006-01-16  3:28             ` Reuben Farrelly
2006-01-16  3:46               ` Alan Stern
2006-01-21  5:21                 ` Reuben Farrelly
2006-01-21  5:47                   ` Andrew Morton
2006-01-21  7:58                     ` Reuben Farrelly
2006-01-21  8:32                       ` Jeff Garzik [this message]
2006-01-21 10:41                         ` [PATCH] " Reuben Farrelly
2006-01-12 10:48 ` [RFC: -mm patch] swsusp: make some code static Adrian Bunk
2006-01-12 15:29   ` Pavel Machek
2006-01-12 16:18     ` Rafael J. Wysocki
2006-01-12 10:48 ` [-mm patch] drivers/block/aoe/aoecmd.c: make aoecmd_cfg_pkts() static Adrian Bunk
2006-01-12 23:55   ` Ed L. Cashin
2006-01-12 21:05 ` 2.6.15-mm3 Rafael J. Wysocki
2006-01-12 21:58   ` 2.6.15-mm3 Andrew Morton
2006-01-12 22:01     ` 2.6.15-mm3 Patrick McHardy
2006-01-13  8:34 ` 2.6.15-mm3 Sachin Sant
2006-01-13 11:52   ` 2.6.15-mm3 Andrew Morton
2006-01-13 21:59     ` 2.6.15-mm3 Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43D1F192.3060406@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@cse.unsw.edu.au \
    --cc=reuben-lkml@reub.net \
    --cc=stern@rowland.harvard.edu \
    --subject='[PATCH] Re: [linux-usb-devel] Re: 2.6.15-mm3 [USB lost interrupt bug]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).