linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oskar Senft <osk-lkml@sirrix.de>
To: linux-kernel@vger.kernel.org
Subject: USB host pci-quirks
Date: Thu, 26 Jan 2006 12:03:12 +0100	[thread overview]
Message-ID: <43D8AC70.70306@sirrix.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

Hi all!

I'm currently working with Linux in a hardware virtualization
environment (L4 microkernel). During tests, we discovered, that there is
some incosistency in the kernel configuration dependencies:

the file "drivers/usb/host/pci-quirks.c" is added to the kernel as soon
as PCI support is activated, even if USB support is completely disabled.

We discovered this issue while trying to run multiple Linux instances
simultaneously.

Is there a special need, that the "drivers/usb/host/pci-quirks.c" is
compiled into the kernel even if USB support is disabled?

I suggest the attached patch to resolve that problem. The file then is
only included if PCI and USB support is enabled.

Best regards,
Oskar.

[-- Attachment #2: pci_but_no_usb-2006-01-24.patch --]
[-- Type: text/plain, Size: 605 bytes --]

--- drivers/usb/host/Makefile.orig	2006-01-24 12:28:11.000000000 +0100
+++ drivers/usb/host/Makefile	2006-01-24 12:27:38.000000000 +0100
@@ -2,7 +2,15 @@
 # Makefile for USB Host Controller Drivers
 #
 
-obj-$(CONFIG_PCI)		+= pci-quirks.o
+# only compile pci-quirks if PCI is enabled
+# and USB is either compiled as a module
+ifeq ($(CONFIG_USB),m)
+	obj-$(CONFIG_PCI)		+= pci-quirks.o
+endif
+# or directly into the kernel
+ifeq ($(CONFIG_USB),y)
+        obj-$(CONFIG_PCI)               += pci-quirks.o
+endif
 
 obj-$(CONFIG_USB_EHCI_HCD)	+= ehci-hcd.o
 obj-$(CONFIG_USB_ISP116X_HCD)	+= isp116x-hcd.o

             reply	other threads:[~2006-01-26 11:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-26 11:03 Oskar Senft [this message]
2006-01-26 22:17 USB host pci-quirks Aleksey Gorelov
2006-01-26 22:38 ` Oskar Senft
2006-01-27  0:47   ` Greg KH
2006-01-27  8:12     ` Oskar Senft
2006-01-26 23:16 Aleksey Gorelov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43D8AC70.70306@sirrix.de \
    --to=osk-lkml@sirrix.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).