From: Paul Fulghum <paulkf@microgate.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Olaf Hering <olh@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] new tty buffering locking fix
Date: Tue, 07 Feb 2006 20:41:04 -0600 [thread overview]
Message-ID: <43E95A40.7010905@microgate.com> (raw)
In-Reply-To: <1139361293.22595.14.camel@localhost.localdomain>
Alan Cox wrote:
> Thats going to hurt memory consumption in the worst cases.
I'll gather some accounting info tomorrow,
and consider the more pathological cases.
> Might be better to document the sane behaviour and enforce it ?
That was my first thought, which prompted my
initial patch of the hvc drivers.
Requiring a call to schedule processing of tty data
after preallocating buffer space is not obvious,
and could result in scheduling work when there is no
data to process.
This semantic twist introduced by my first locking patch
is a hazard for driver writers, and would require an audit
of existing drivers (as demonstrated by Olaf's report).
--
Paul Fulghum
Microgate Systems, Ltd
next prev parent reply other threads:[~2006-02-08 2:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200602032312.k13NCbWb012991@hera.kernel.org>
2006-02-07 12:34 ` [PATCH] new tty buffering locking fix Olaf Hering
2006-02-07 16:21 ` Paul Fulghum
2006-02-07 17:11 ` Olaf Hering
2006-02-07 18:47 ` Paul Fulghum
2006-02-07 21:27 ` Paul Fulghum
2006-02-08 1:14 ` Alan Cox
2006-02-08 2:41 ` Paul Fulghum [this message]
2006-02-08 2:56 ` Paul Fulghum
2006-02-08 22:05 ` Paul Fulghum
2006-02-08 22:39 ` Olaf Hering
2006-01-26 20:33 Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43E95A40.7010905@microgate.com \
--to=paulkf@microgate.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).