From: Dmitry Osipenko <digetx@gmail.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Krishna Reddy <vdumpa@nvidia.com>, Will Deacon <will@kernel.org>,
linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] iommu/tegra-smmu: Change debugfs directory name
Date: Wed, 14 Jul 2021 14:17:48 +0300 [thread overview]
Message-ID: <43abb785-8b6a-555b-7d66-fa1911d2f8a0@gmail.com> (raw)
In-Reply-To: <YO7B56Mkz3kx5U5Q@8bytes.org>
14.07.2021 13:52, Joerg Roedel пишет:
> On Mon, Jul 12, 2021 at 03:13:41AM +0300, Dmitry Osipenko wrote:
>> - err = iommu_device_sysfs_add(&smmu->iommu, dev, NULL, dev_name(dev));
>> + err = iommu_device_sysfs_add(&smmu->iommu, dev, NULL, "smmu");
>
> Are you sure no one is relying on the old name so that this change
> breaks ABI?
IIUC, Thierry and Jon have a testing suite that uses the old name, but
it shouldn't be a problem to support the new name in addition to the old
name since it's internal/private testing suite.
The reason I'm proposing this change is because it's not obvious where
the SMMU debug is located when you look at the debugfs directory, it
takes some effort to find it.
> Also this change means that there is always be only one SMMU
> per system. Is that guaranteed too?
A single SMMU is guaranteed here. Only latest Tegra SoCs have two SMMUs
and those are ARM SMMUs, while this is a legacy Tegra SMMU here.
prev parent reply other threads:[~2021-07-14 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 0:13 [PATCH v1] iommu/tegra-smmu: Change debugfs directory name Dmitry Osipenko
2021-07-14 10:52 ` Joerg Roedel
2021-07-14 11:17 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43abb785-8b6a-555b-7d66-fa1911d2f8a0@gmail.com \
--to=digetx@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vdumpa@nvidia.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).