From: Trevor Wu <trevor.wu@mediatek.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
Bicycle Tsai <bicycle.tsai@mediatek.com>
Subject: Re: linux-next: Tree for Sep 1 [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko]
Date: Thu, 2 Sep 2021 16:50:57 +0800 [thread overview]
Message-ID: <43d231a765a2106b6ef0cbbe842ba3ec37b45878.camel@mediatek.com> (raw)
In-Reply-To: <CAMuHMdXVxNfQYwP7+iMq+CbuDx3wjHgG2xsr9jP4WwL4OLLL-Q@mail.gmail.com>
On Thu, 2021-09-02 at 10:22 +0200, Geert Uytterhoeven wrote:
> Hi Trevor,
>
> On Thu, Sep 2, 2021 at 4:37 AM Trevor Wu <trevor.wu@mediatek.com>
> wrote:
> > On Wed, 2021-09-01 at 13:55 -0700, Randy Dunlap wrote:
> > > On 9/1/21 1:17 AM, Stephen Rothwell wrote:
> > > > Please do not add any v5.16 related code to your linux-next
> > > > included
> > > > branches until after v5.15-rc1 has been released.
> > > >
> > > > Changes since 20210831:
> > > >
> > >
> > >
> > > on x86_64:
> > >
> > > ERROR: modpost: "clkdev_add" [sound/soc/mediatek/mt8195/snd-soc-
> > > mt8195-afe.ko] undefined!
> > > ERROR: modpost: "clkdev_drop" [sound/soc/mediatek/mt8195/snd-soc-
> > > mt8195-afe.ko] undefined!
> > > ERROR: modpost: "clk_unregister_gate"
> > > [sound/soc/mediatek/mt8195/snd-
> > > soc-mt8195-afe.ko] undefined!
> > > ERROR: modpost: "clk_register_gate"
> > > [sound/soc/mediatek/mt8195/snd-
> > > soc-mt8195-afe.ko] undefined!
> > >
> > > Full randconfig file is attached.
> > >
> >
> > Hi Randy,
> >
> > The problem is caused by the dependency declaration, because it's
> > not a
> > driver for x86_64.
> > The dependency declaration has been added in the following patch.
> >
> >
https://urldefense.com/v3/__https://patchwork.kernel.org/project/alsa-devel/patch/7e628e359bde04ceb9ddd74a45931059b4a4623c.1630415860.git.geert*renesas@glider.be/__;Kw!!CTRNKA9wMg0ARbw!wMq130mAo-s45pP6ShQ1S8UIRuJLhwOnCbQNAQHIE2zvNhjAd67h1rlqkIDxJvC5_g$
> >
>
> That is not sufficient, if COMPILE_TEST is enabled.
>
> Looks like it needs a dependency on COMMON_CLK, too.
>
> Gr{oetje,eeting}s,
>
> Geert
>
Hi Geert,
Because it's a ARM64 driver, ARM64 will select COMMON_CLK.
It seems that some dependency should be checked if COMPILE_TEST is
enabled and the driver is compiled on non-ARM64 environment.
We don't expect the driver can be used on non-ARM64 environment,may I
remove COMPILE_TEST to solve the problem?
If the driver only depends on ARCH_MEDIATEK, it must be compiled on
ARM64.
Thanks,
Trevor
next prev parent reply other threads:[~2021-09-02 8:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 8:17 linux-next: Tree for Sep 1 Stephen Rothwell
2021-09-01 20:55 ` linux-next: Tree for Sep 1 [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] Randy Dunlap
2021-09-02 2:35 ` Trevor Wu
2021-09-02 8:22 ` Geert Uytterhoeven
2021-09-02 8:50 ` Trevor Wu [this message]
2021-09-02 9:15 ` Chen-Yu Tsai
2021-09-03 7:05 ` Trevor Wu
2021-09-03 7:17 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43d231a765a2106b6ef0cbbe842ba3ec37b45878.camel@mediatek.com \
--to=trevor.wu@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=bicycle.tsai@mediatek.com \
--cc=broonie@kernel.org \
--cc=geert@linux-m68k.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).