From: Dan Murphy <dmurphy@ti.com>
To: David Miller <davem@davemloft.net>
Cc: <andrew@lunn.ch>, <f.fainelli@gmail.com>, <hkallweit1@gmail.com>,
<robh@kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH net-next v9 2/5] net: phy: Add a helper to return the index for of the internal delay
Date: Mon, 22 Jun 2020 20:19:00 -0500 [thread overview]
Message-ID: <43e0247e-a62a-b34e-016f-c2e540591df2@ti.com> (raw)
In-Reply-To: <20200622.154047.909380525276436349.davem@davemloft.net>
David
On 6/22/20 5:40 PM, David Miller wrote:
> From: Dan Murphy <dmurphy@ti.com>
> Date: Fri, 19 Jun 2020 11:18:10 -0500
>
>> +s32 phy_get_internal_delay(struct phy_device *phydev, struct device *dev,
>> + const int *delay_values, int size, bool is_rx)
>> +{
>> + int i;
>> + s32 delay;
> Please use reverse christmas tree ordering for local variables.
OK.
Dan
next prev parent reply other threads:[~2020-06-23 1:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 16:18 [PATCH net-next v9 0/5] RGMII Internal delay common property Dan Murphy
2020-06-19 16:18 ` [PATCH net-next v9 1/5] dt-bindings: net: Add tx and rx internal delays Dan Murphy
2020-06-22 22:40 ` David Miller
2020-06-23 1:18 ` Dan Murphy
2020-06-19 16:18 ` [PATCH net-next v9 2/5] net: phy: Add a helper to return the index for of the internal delay Dan Murphy
2020-06-22 22:40 ` David Miller
2020-06-23 1:19 ` Dan Murphy [this message]
2020-06-19 16:18 ` [PATCH net-next v9 3/5] dt-bindings: net: Add RGMII internal delay for DP83869 Dan Murphy
2020-06-19 16:18 ` [PATCH net-next v9 4/5] net: dp83869: Add RGMII internal delay configuration Dan Murphy
2020-06-19 16:18 ` [PATCH net-next v9 5/5] net: phy: DP83822: Add setting the fixed internal delay Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43e0247e-a62a-b34e-016f-c2e540591df2@ti.com \
--to=dmurphy@ti.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).