On 09/09/2016, 12:35 AM, Kees Cook wrote:
> The ptmx_fops structure is only changed during init, so mark it as such.

Right, but I am missing what is the benefit? You would have to elaborate
here...

> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  drivers/tty/pty.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c
> index 51e0d32883ba..a23fa5ed1d67 100644
> --- a/drivers/tty/pty.c
> +++ b/drivers/tty/pty.c
> @@ -800,7 +800,7 @@ out_free_file:
>  	return retval;
>  }
>  
> -static struct file_operations ptmx_fops;
> +static struct file_operations ptmx_fops __ro_after_init;
>  
>  static void __init unix98_pty_init(void)
>  {
> 

thanks,
-- 
js
suse labs