From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751877AbWB1EMA (ORCPT ); Mon, 27 Feb 2006 23:12:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751871AbWB1EL7 (ORCPT ); Mon, 27 Feb 2006 23:11:59 -0500 Received: from rtr.ca ([64.26.128.89]:54683 "EHLO mail.rtr.ca") by vger.kernel.org with ESMTP id S1751816AbWB1EL6 (ORCPT ); Mon, 27 Feb 2006 23:11:58 -0500 Message-ID: <4403CD8C.1080603@rtr.ca> Date: Mon, 27 Feb 2006 23:11:56 -0500 From: Mark Lord User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060130 SeaMonkey/1.0 MIME-Version: 1.0 To: Jeff Garzik Cc: Linus Torvalds , Tejun Heo , David Greaves , Justin Piszcz , linux-kernel@vger.kernel.org, IDE/ATA development list , albertcc@tw.ibm.com, axboe@suse.de Subject: Re: LibPATA code issues / 2.6.15.4 References: <43F2050B.8020006@dgreaves.com> <200602141300.37118.lkml@rtr.ca> <440040B4.8030808@dgreaves.com> <440083B4.3030307@rtr.ca> <4400A1BF.7020109@rtr.ca> <4400B439.8050202@dgreaves.com> <4401122A.3010908@rtr.ca> <44017B4B.3030900@dgreaves.com> <4401B560.40702@rtr.ca> <4403704E.4090109@rtr.ca> <4403A84C.6010804@gmail.com> <4403B04F.5090405@pobox.com> <4403C546.7030702@pobox.com> In-Reply-To: <4403C546.7030702@pobox.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jeff Garzik wrote: > Linus Torvalds wrote: .. >> I really hate having a _global_ variable called "fua". That's just bad >> taste. I would suggest calling it "atapi_forced_unit_attention_enabled" Heh heh.. It's actually short for "Force Unit Access", though oddly enough I don't think the patch mentions that in the MODULE_PARM_DESC(). > Here's the cleaner namespace version... David, do you want to ack this one for us? Cheers