LKML Archive on lore.kernel.org
 help / color / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Gleb Natapov <gleb@minantech.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Dirk Brandewie <dirk.brandewie@gmail.com>,
	Kashyap Chamarthy <kchamart@redhat.com>,
	Josh Boyer <jwboyer@fedoraproject.org>,
	One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
	Linux PM list <linux-pm@vger.kernel.org>,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
	"Richard W.M. Jones" <rjones@redhat.com>
Subject: Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad
Date: Sat, 04 Jan 2014 22:38:33 +0100
Message-ID: <4410803.FiVxaMNxvJ@vostro.rjw.lan> (raw)
In-Reply-To: <20140104174813.GL10961@minantech.com>

On Saturday, January 04, 2014 07:48:13 PM Gleb Natapov wrote:
> On Sat, Jan 04, 2014 at 06:38:59PM +0100, Paolo Bonzini wrote:
> > Il 04/01/2014 15:38, Rafael J. Wysocki ha scritto:
> > > Well, it's just a sanity check and it makes the problem go away for the reporter.
> > > 
> > >> > Your patch is welcome but perhaps it should have a WARN_ON too.
> > > It has been pulled in already, so the WARN_ON() can only be added via a separate
> > > patch now.  Would you like to prepare that patch?
> > 
> > Yes, I'll add it together with the CPUID check.  I'll send the patch so
> > that it can get into 3.14.
> > 
> CPUID check, while correct, will sweep the problem under the rug. Current
> Linux logic should detect non working pstate in KVM. We should look into
> why this is not happening for nested.

I agree.  It's better not to use CPUID for that in my opinion.

Thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

  reply index

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-24 14:36 Josh Boyer
2013-12-24 16:06 ` Viresh Kumar
2013-12-27 12:24   ` One Thousand Gnomes
2013-12-27 12:47     ` Gleb Natapov
2013-12-27 13:46       ` Josh Boyer
2013-12-27 14:15         ` Kashyap Chamarthy
2013-12-27 14:34           ` Richard W.M. Jones
2013-12-27 16:52           ` Gleb Natapov
2013-12-27 17:01             ` Gleb Natapov
2013-12-27 17:17               ` Richard W.M. Jones
2013-12-27 17:17               ` Kashyap Chamarthy
2013-12-27 21:51                 ` Rafael J. Wysocki
2013-12-29 12:12                   ` Kashyap Chamarthy
2013-12-29 15:04                     ` Rafael J. Wysocki
2013-12-30 14:58                       ` Kashyap Chamarthy
2013-12-31  2:07                         ` Rafael J. Wysocki
2014-01-03 17:30                           ` Dirk Brandewie
2014-01-03 18:04                             ` Gleb Natapov
2014-01-03 20:00                               ` Dirk Brandewie
2014-01-03 22:06                                 ` Paolo Bonzini
2014-01-06 17:18                                   ` Dirk Brandewie
2014-01-07 16:11                                     ` Gleb Natapov
2014-01-03 22:46                               ` Rafael J. Wysocki
2014-01-04  8:35                                 ` Paolo Bonzini
2014-01-04 14:38                                   ` Rafael J. Wysocki
2014-01-04 17:38                                     ` Paolo Bonzini
2014-01-04 17:48                                       ` Gleb Natapov
2014-01-04 21:38                                         ` Rafael J. Wysocki [this message]
2014-01-06 11:20                                           ` Paolo Bonzini
2014-01-06 11:37                                             ` Rafael J. Wysocki
2014-01-06 18:40                                               ` Dirk Brandewie
2013-12-27 14:35   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4410803.FiVxaMNxvJ@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=cpufreq@vger.kernel.org \
    --cc=dirk.brandewie@gmail.com \
    --cc=gleb@minantech.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=jwboyer@fedoraproject.org \
    --cc=kchamart@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rjones@redhat.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git