From: Bean Huo <huobean@gmail.com>
To: Po-Wen Kao <powen.kao@mediatek.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: wsd_upstream@mediatek.com, peter.wang@mediatek.com,
stanley.chu@mediatek.com, alice.chao@mediatek.com,
chun-hung.wu@mediatek.com, cc.chou@mediatek.com,
chaotian.jing@mediatek.com, jiajie.hao@mediatek.com,
yohan.joung@sk.com, jason.li@sk.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/1] scsi: ufs: remove redundant HPB unmap
Date: Fri, 15 Apr 2022 00:07:56 +0200 [thread overview]
Message-ID: <44108a7ad56dd6984523af35cfa003f4ed7be41e.camel@gmail.com> (raw)
In-Reply-To: <004b55d8-fcd3-136c-526c-6ada025d6a1c@mediatek.com>
On Thu, 2022-04-14 at 12:49 +0800, Po-Wen Kao wrote:
> Hi Bean,
>
> The general idea looks good.
>
> As ufshpb_issue_umap_all_req in ufshpb_state_toggle won't actually
> runs
> at cold boot probe due to the fact that sdev are not present yet,
> this
> should avoid sending HPB command before UAC being cleared while keeps
> HPB mapping clean when rest flow occurs.
>
> Just a concern, shouldn't ufshpb_issue_umap_all_req be send for each
> sdev's corresponding hpb?
>
Hi Po Wen,
I replied in another email that setting the flag resets all active
regions in the device, which is a more efficient way, I have submitted
a fix for HPB device mode, your review and testing are welcome.
Kind regards,
Bean
> Looking forward to your further fixes.
>
>
next prev parent reply other threads:[~2022-04-14 22:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 7:31 [PATCH 1/1] scsi: ufs: remove redundant HPB unmap Po-Wen Kao
2022-04-12 15:06 ` Bean Huo
2022-04-12 15:20 ` Bean Huo
2022-04-13 3:53 ` Peter Wang
2022-04-13 12:43 ` Bean Huo
2022-04-14 4:49 ` Po-Wen Kao
2022-04-14 22:07 ` Bean Huo [this message]
2022-04-13 21:29 ` Bean Huo
2022-04-26 4:00 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44108a7ad56dd6984523af35cfa003f4ed7be41e.camel@gmail.com \
--to=huobean@gmail.com \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=jason.li@sk.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
--cc=powen.kao@mediatek.com \
--cc=stanley.chu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
--cc=yohan.joung@sk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).