From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Jiri Kosina <trivial@kernel.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: merge max1619 into trivial devices
Date: Fri, 20 Aug 2021 07:26:43 -0700 [thread overview]
Message-ID: <441b28c9-a997-7143-825f-f272e399d60f@roeck-us.net> (raw)
In-Reply-To: <20210819182544.224121-1-krzysztof.kozlowski@canonical.com>
On 8/19/21 11:25 AM, Krzysztof Kozlowski wrote:
> Ther Maxim max1619 bindings are trivial, so simply merge it into
> trivial-devices.yaml.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Do we have a general guideline on how to handle such trivial bindings ?
I normally leave it up to the driver author to decide one way or another.
Guenter
> ---
> Documentation/devicetree/bindings/hwmon/max1619.txt | 12 ------------
> .../devicetree/bindings/trivial-devices.yaml | 2 ++
> 2 files changed, 2 insertions(+), 12 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/hwmon/max1619.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/max1619.txt b/Documentation/devicetree/bindings/hwmon/max1619.txt
> deleted file mode 100644
> index c70dbbe1e56f..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/max1619.txt
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -Bindings for MAX1619 Temperature Sensor
> -
> -Required properties:
> -- compatible : "maxim,max1619"
> -- reg : I2C address, one of 0x18, 0x19, 0x1a, 0x29, 0x2a, 0x2b, 0x4c, or
> - 0x4d, 0x4e
> -
> -Example:
> - temp@4c {
> - compatible = "maxim,max1619";
> - reg = <0x4c>;
> - };
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index fb03febc6616..1e4b3464d734 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -147,6 +147,8 @@ properties:
> - maxim,ds1803-100
> # Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs
> - maxim,max1237
> + # Temperature Sensor, I2C interface
> + - maxim,max1619
> # 10-bit 10 kOhm linear programable voltage divider
> - maxim,max5481
> # 10-bit 50 kOhm linear programable voltage divider
>
next prev parent reply other threads:[~2021-08-20 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 18:25 [PATCH 1/2] dt-bindings: hwmon: merge max1619 into trivial devices Krzysztof Kozlowski
2021-08-19 18:25 ` [PATCH 2/2] dt-bindings: hwmon: merge max31785 " Krzysztof Kozlowski
2021-08-20 14:23 ` Guenter Roeck
2021-08-23 21:12 ` Rob Herring
2021-08-20 14:26 ` Guenter Roeck [this message]
2021-08-23 21:19 ` [PATCH 1/2] dt-bindings: hwmon: merge max1619 " Rob Herring
2021-08-31 15:21 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=441b28c9-a997-7143-825f-f272e399d60f@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).