From: "Fabio M. De Francesco" <firstname.lastname@example.org> To: Dan Carpenter <email@example.com> Cc: "Suren Baghdasaryan" <firstname.lastname@example.org>, "Greg Kroah-Hartman" <email@example.com>, "Arve Hjønnevåg" <firstname.lastname@example.org>, "Todd Kjos" <email@example.com>, "Martijn Coenen" <firstname.lastname@example.org>, "Joel Fernandes" <email@example.com>, "Christian Brauner" <firstname.lastname@example.org>, "Hridya Valsaraju" <email@example.com>, LKML <firstname.lastname@example.org>, email@example.com Subject: Re: [PATCH] staging: android: Remove set but unused variable in ashmem.c Date: Wed, 28 Jul 2021 14:00:19 +0200 [thread overview] Message-ID: <4425350.seJdf4cM5h@localhost.localdomain> (raw) In-Reply-To: <20210726134454.GJ1931@kadam> Hello Dan, On Monday, July 26, 2021 3:44:54 PM CEST Dan Carpenter wrote: > On Sat, Jul 24, 2021 at 09:49:35AM +0200, Fabio M. De Francesco wrote: > > > > [...] > > > Another trick which would have helped is to try find out which patch > forgot to remove the "inode" variable, because that developer would have > seen the warning as well. > > > > I'm guessing you are building with CONFIG_LOCKDEP=n. > > > > Actually my .config sets CONFIG_LOCKDEP_SUPPORT=y. Did you refer to this? > > There is no CONFIG_LOCKDEP in the file. > > Use make nconfig and then use f8 to search for CONFIG_LOCKDEP. > > regards, > dan carpenter Thanks a lot. As always, you've been very helpful. I appreciate your willingness to help and, more generally, your attitude towards people with less experience than yours. By using F8, I found that CONFIG_LOCKDEP is selected by CONFIG_LOCK_STAT (in logical AND with other options) but, in my .config, the latter was set to 'n'. After setting this other option to 'y', CONFIG_LOCKDEP magically :) appeared in .config and it was automatically set to 'y'. I see that the same kind of search can also be done by using the slash if one uses "make menuconfig". Regards, Fabio
next prev parent reply other threads:[~2021-07-28 12:00 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-23 20:05 Fabio M. De Francesco 2021-07-23 20:14 ` Suren Baghdasaryan 2021-07-24 7:49 ` Fabio M. De Francesco 2021-07-26 13:44 ` Dan Carpenter 2021-07-28 12:00 ` Fabio M. De Francesco [this message] 2021-07-24 2:53 ` kernel test robot 2021-07-24 3:14 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4425350.seJdf4cM5h@localhost.localdomain \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] staging: android: Remove set but unused variable in ashmem.c' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).