From: Yi Yang <yang.y.yi@gmail.com>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Matt Helsley <matthltc@us.ibm.com>
Subject: Re: [2.6.16 PATCH] Filessytem Events Reporter V2
Date: Fri, 07 Apr 2006 23:14:27 +0800 [thread overview]
Message-ID: <443681D3.8000805@gmail.com> (raw)
In-Reply-To: <20060407102602.GA27764@2ka.mipt.ru>
Evgeniy Polyakov 写道:
> On Fri, Apr 07, 2006 at 06:03:04PM +0800, Yi Yang (yang.y.yi@gmail.com) wrote:
>
>>>> Can you explain why there is such a big difference between
>>>> netlink_unicast and netlink_broadcast?
>>>>
>>>>
>>> Netlink broadcast clones skbs, while unicasting requires the whole new
>>> one.
>>>
>>>
>> No, I also use clone to send skb, so they should have the same overhead.
>>
>
> I missed that.
> After rereading fsevent_send_to_process() I do not see how original skb
> is freed though.
>
I'm considering how to free it, because cloned skbs share data with
original skb, so this case is special,
I try to clarify the logic of kfree_skb.
>
>>>>> Btw, you need some rebalancing of the per-cpu queues, probably in
>>>>> keventd, since CPUs can go offline and your messages will stuck foreve
>>>>> there.
>>>>>
>>>>>
>>>>>
>>>> Does keventd not do it? if so, keventd should be modified.
>>>>
>>>>
>>> How does keventd know about your own structures?
>>> You have an per-cpu object, but your keventd function gets object
>>>
>> >from running cpu, not from any other cpus.
>>
>
>
next prev parent reply other threads:[~2006-04-07 15:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-05 13:21 [2.6.16 PATCH] Filessytem Events Reporter V2 Yi Yang
2006-04-05 17:12 ` Carlos Silva
2006-04-05 23:45 ` Yi Yang
2006-04-07 6:24 ` Evgeniy Polyakov
2006-04-07 8:13 ` Yi Yang
2006-04-07 9:47 ` Evgeniy Polyakov
2006-04-07 10:03 ` Yi Yang
2006-04-07 10:26 ` Evgeniy Polyakov
2006-04-07 15:14 ` Yi Yang [this message]
2006-04-07 19:47 ` Evgeniy Polyakov
2006-04-07 20:27 ` Evgeniy Polyakov
2006-04-05 14:13 Michael Guo
2006-04-05 23:44 ` Yi Yang
2006-04-06 14:34 Michael Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443681D3.8000805@gmail.com \
--to=yang.y.yi@gmail.com \
--cc=akpm@osdl.org \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).